Make GitHub integration free for all users#3152
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughRemoved GitHub feature-flag gating and made GitHub integration visible on the free plan; updated billing comparison rows; replaced GitHub demo assets with Slack in the paywall preview and adjusted synced item type/display. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR makes the GitHub integration freely available to all users by removing the PostHog Key changes:
Confidence Score: 5/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[User opens Integrations] --> B{Platform?}
B -->|Web| C[integrations/page.tsx]
B -->|Desktop| D[IntegrationsSettings.tsx]
C --> E{Integration?}
E -->|GitHub| F[Always visible ✅]
E -->|Slack| G{hasSlackAccess flag?}
G -->|Yes| H[Show Slack card]
G -->|No| I[Hidden]
E -->|Linear| J[Show Linear card via isItemVisible]
D --> K{Integration?}
K -->|GitHub| L[isItemVisible only — no flag gate ✅]
L --> M[onManage → open web directly ✅]
K -->|Slack| N{hasSlackAccess flag?}
N -->|Yes| O[Show → gateFeature paywall]
K -->|Linear| P[isItemVisible → gateFeature paywall]
subgraph Paywall Preview Updated
Q[IntegrationsDemo] --> R[Linear ↔ Slack ✅]
end
subgraph Billing Updated
S[Free plan features] --> T[+ GitHub integration ✅]
U[Comparison table] --> V[GitHub = Free ✅]
U --> W[Slack = Pro/Enterprise ✅]
end
Reviews (1): Last reviewed commit: "feat: make GitHub integration free for a..." | Re-trigger Greptile |
Remove the PostHog feature flag gate and desktop paywall from the GitHub integration so it is accessible to all plan tiers. Update billing plans to reflect GitHub as a free feature and replace GitHub with Slack in the pro features paywall preview.
a80144e to
f99e86f
Compare
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
apps/desktop/src/renderer/routes/_authenticated/settings/billing/plans/page.tsx (1)
138-157: Consider a single source for integration entitlements.
PLANS.free.featuresnow carries GitHub, while this comparison matrix separately hard-codes GitHub and Slack availability. Since other billing views already renderplan.features, keeping both structures aligned will get brittle quickly. Consider deriving these rows from shared plan-entitlement data instead of duplicating them here.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/desktop/src/renderer/routes/_authenticated/settings/billing/plans/page.tsx` around lines 138 - 157, The comparison matrix duplicates integration entitlements that already live on PLANS (e.g., PLANS.free.features) and plan.features; remove the hard-coded rows ("GitHub integration", "Slack integration", etc.) and instead derive those rows from a single source of truth by mapping the shared plan entitlement data (PLANS[*].features or plan.features) into the comparison rows; implement a small mapper or helper used by the page component to produce label, values and comingSoon from the feature keys so the matrix always reflects PLANS entries and avoids divergence.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@apps/desktop/src/renderer/routes/_authenticated/settings/billing/plans/page.tsx`:
- Around line 138-157: The comparison matrix duplicates integration entitlements
that already live on PLANS (e.g., PLANS.free.features) and plan.features; remove
the hard-coded rows ("GitHub integration", "Slack integration", etc.) and
instead derive those rows from a single source of truth by mapping the shared
plan entitlement data (PLANS[*].features or plan.features) into the comparison
rows; implement a small mapper or helper used by the page component to produce
label, values and comingSoon from the feature keys so the matrix always reflects
PLANS entries and avoids divergence.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: ff75364d-27b7-4dec-95d8-aca5ecefd3aa
📒 Files selected for processing (6)
apps/desktop/src/renderer/components/Paywall/components/FeaturePreview/components/IntegrationsDemo/IntegrationsDemo.tsxapps/desktop/src/renderer/components/Paywall/constants.tsapps/desktop/src/renderer/routes/_authenticated/settings/billing/constants.tsapps/desktop/src/renderer/routes/_authenticated/settings/billing/plans/page.tsxapps/desktop/src/renderer/routes/_authenticated/settings/integrations/components/IntegrationsSettings/IntegrationsSettings.tsxapps/web/src/app/(dashboard-legacy)/integrations/page.tsx
Remove the PostHog feature flag gate and desktop paywall from the GitHub integration so it is accessible to all plan tiers. Update billing plans to reflect GitHub as a free feature and replace GitHub with Slack in the pro features paywall preview.
cherry-pick方式で内容を取り込み済みの14コミットをgit履歴上もマージ済みにする。 取り込み済み (cherry-pick / 手動移植): - be22b46 superset-sh#3125 — スキップ (下記参照) - 88bc7fb superset-sh#3127 — Revert DA1 ✓ - 92d0ff9 superset-sh#3054 — DA1 fix ✓ - c48450e superset-sh#3093 — file viewer pane fix ✓ - fffa8db superset-sh#3128 — version 1.4.7 ✓ - 589a7c7 superset-sh#3136 — fuzzy scorer (ハイブリッド方式) ✓ - ceb8c81 superset-sh#3150 — Electron 40.8.5 ✓ - 8922b94 superset-sh#3137 — terminalId分離 ✓ - c7508e5 superset-sh#3152 — GitHub無料化 ✓ - 2b91f11 superset-sh#3155 — v2 terminal theme ✓ - b8b11af superset-sh#3154 — TUI dimension fix ✓ - 7599ace superset-sh#3149 — v2 sidebar file tree (手動統合) ✓ - 4d7c612 superset-sh#3174 — DnD重複削除 ✓ - 864977d superset-sh#3157 — Host Service分離 ✓ 意図的にスキップ: - be22b46 superset-sh#3125 (GitHub polling簡素化) フォーク独自のGitHubSyncService (バックエンド集中ポーリング) と 設計が異なるため不採用。upstreamはフロントエンドhover駆動、フォークは バックエンドキャッシュウォーマー方式。詳細は githubQueryPolicy.ts と github-sync-service.ts のFORK NOTEを参照。 ゴースト・マージ復元 (revert 134cfd5 で消失した内容): - 538f306 superset-sh#3120 — Patch vuln ✓ - 1588d20 superset-sh#3108 — terminal lifecycle分離 ✓ - 59426f6 superset-sh#3122 — file tree + FilePane + Alert refactor (手動統合) ✓ - 10d9a5d superset-sh#3097 — tiptap line-height ✓ - 337a9ae superset-sh#3121 — Codex hooks削除 ✓
Summary
GITHUB_INTEGRATION_ACCESS) from the GitHub integration on both web and desktop, making it visible to all usersgateFeature) from the GitHub integration's "Manage" button so free users can access it directlyTest plan
Summary by cubic
Make the GitHub integration free for all users by removing the feature flag and desktop paywall. Update plans and the paywall preview to show Slack as the gated integration instead.
GITHUB_INTEGRATION_ACCESSon web and desktop; GitHub card is always visible.gateFeatureon GitHub Manage; free users can connect/manage directly.Written for commit f99e86f. Summary will update on new commits.
Summary by CodeRabbit
New Features
Bug Fixes