Skip to content

fix(desktop): remove PreToolUse/PostToolUse hooks from Codex #3121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kitenite merged 1 commit into from
Apr 2, 2026
+19 −89
Merged

fix(desktop): remove PreToolUse/PostToolUse hooks from Codex #3121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/desktop/docs/EXTERNAL_FILES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ its hook entries into these files while preserving user-defined entries:
| File | Purpose |
|------|---------|
| `~/.claude/settings.json` | Claude Code hook registration merge |
| `~/.codex/hooks.json` | Codex hook registration merge (`SessionStart`, `UserPromptSubmit`, `PreToolUse`, `PostToolUse`, `Stop`) |
| `~/.codex/hooks.json` | Codex hook registration merge (`SessionStart`, `UserPromptSubmit`, `Stop`) |
| `~/.factory/settings.json` | Factory Droid hook registration (`UserPromptSubmit`, `Notification`, `PostToolUse`, `Stop`) |

For Codex specifically, Superset now relies on native `~/.codex/hooks.json`
Expand Down
21 changes: 1 addition & 20 deletions apps/desktop/src/main/lib/agent-setup/agent-wrappers-claude-codex-opencode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,12 +385,7 @@ export function getCodexGlobalHooksJsonContent(
}

const managedEvents: Array<{
eventName:
| "SessionStart"
| "UserPromptSubmit"
| "PreToolUse"
| "PostToolUse"
| "Stop";
eventName: "SessionStart" | "UserPromptSubmit" | "Stop";
definition: ClaudeHookDefinition;
}> = [
{
Expand All @@ -405,20 +400,6 @@ export function getCodexGlobalHooksJsonContent(
hooks: [{ type: "command", command: notifyScriptPath }],
},
},
{
eventName: "PreToolUse",
definition: {
matcher: "*",
hooks: [{ type: "command", command: notifyScriptPath }],
},
},
{
eventName: "PostToolUse",
definition: {
matcher: "*",
hooks: [{ type: "command", command: notifyScriptPath }],
},
},
{
eventName: "Stop",
definition: {
Expand Down
85 changes: 17 additions & 68 deletions apps/desktop/src/main/lib/agent-setup/agent-wrappers.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -888,7 +888,7 @@ describe("agent-wrappers codex hooks.json", () => {
rmSync(TEST_ROOT, { recursive: true, force: true });
});

it("creates Codex hooks.json with prompt and tool lifecycle hooks when no file exists", () => {
it("creates Codex hooks.json with prompt and lifecycle hooks when no file exists", () => {
const notifyPath = "/tmp/.superset/hooks/notify.sh";
const content = getCodexGlobalHooksJsonContent(notifyPath);
expect(content).not.toBeNull();
Expand All @@ -907,8 +907,6 @@ describe("agent-wrappers codex hooks.json", () => {
for (const eventName of [
"SessionStart",
"UserPromptSubmit",
"PreToolUse",
"PostToolUse",
"Stop",
] as const) {
const hooks = parsed.hooks[eventName];
Expand All @@ -920,12 +918,8 @@ describe("agent-wrappers codex hooks.json", () => {
).toBe(true);
}

expect(parsed.hooks.PreToolUse?.every((def) => def.matcher === "*")).toBe(
true,
);
expect(parsed.hooks.PostToolUse?.every((def) => def.matcher === "*")).toBe(
true,
);
expect(parsed.hooks.PreToolUse).toBeUndefined();
expect(parsed.hooks.PostToolUse).toBeUndefined();
});

it("preserves user hooks when merging", () => {
Expand Down Expand Up @@ -987,7 +981,7 @@ describe("agent-wrappers codex hooks.json", () => {

const parsed = JSON.parse(content);

// Preserves user hook
// Preserves user hooks (including PreToolUse/PostToolUse which we don't manage)
expect(
parsed.hooks.Stop.some((def: { hooks: Array<{ command: string }> }) =>
def.hooks.some(
Expand Down Expand Up @@ -1024,78 +1018,35 @@ describe("agent-wrappers codex hooks.json", () => {
),
).toBe(true);

// Adds managed hook
expect(
parsed.hooks.Stop.some((def: { hooks: Array<{ command: string }> }) =>
def.hooks.some(
(hook: { command: string }) => hook.command === notifyPath,
// Adds managed hooks for SessionStart, UserPromptSubmit, Stop
for (const eventName of ["SessionStart", "UserPromptSubmit", "Stop"]) {
expect(
parsed.hooks[eventName].some(
(def: { hooks: Array<{ command: string }> }) =>
def.hooks.some(
(hook: { command: string }) => hook.command === notifyPath,
),
),
),
).toBe(true);
).toBe(true);
}

// Also creates prompt + start hooks
expect(
parsed.hooks.SessionStart.some(
(def: { hooks: Array<{ command: string }> }) =>
def.hooks.some(
(hook: { command: string }) => hook.command === notifyPath,
),
),
).toBe(true);
expect(
parsed.hooks.UserPromptSubmit.some(
(def: { hooks: Array<{ command: string }> }) =>
def.hooks.some(
(hook: { command: string }) => hook.command === notifyPath,
),
),
).toBe(true);
// Does NOT inject managed hooks for PreToolUse/PostToolUse
expect(
parsed.hooks.PreToolUse.some(
(def: { hooks: Array<{ command: string }> }) =>
def.hooks.some(
(hook: { command: string }) => hook.command === notifyPath,
),
),
).toBe(true);
).toBe(false);
expect(
parsed.hooks.PostToolUse.some(
(def: { hooks: Array<{ command: string }> }) =>
def.hooks.some(
(hook: { command: string }) => hook.command === notifyPath,
),
),
).toBe(true);
});

it("adds UserPromptSubmit, PreToolUse, and PostToolUse to the Codex hooks.json merge", () => {
const notifyPath = "/tmp/.superset/hooks/notify.sh";
const content = getCodexGlobalHooksJsonContent(notifyPath);
expect(content).not.toBeNull();
if (content === null) throw new Error("Expected content");

const parsed = JSON.parse(content) as {
hooks: Record<
string,
Array<{
matcher?: string;
hooks: Array<{ type: string; command: string }>;
}>
>;
};

for (const eventName of [
"UserPromptSubmit",
"PreToolUse",
"PostToolUse",
] as const) {
expect(parsed.hooks[eventName]).toBeDefined();
expect(
parsed.hooks[eventName]?.some((def) =>
def.hooks.some((hook) => hook.command === notifyPath),
),
).toBe(true);
}
).toBe(false);
});

it("replaces stale Codex hook commands from old superset paths", () => {
Expand Down Expand Up @@ -1150,8 +1101,6 @@ describe("agent-wrappers codex hooks.json", () => {
for (const eventName of [
"SessionStart",
"UserPromptSubmit",
"PreToolUse",
"PostToolUse",
"Stop",
] as const) {
const hooks = parsed.hooks[eventName];
Expand Down
Loading