Fix neon setup/teardown scripts

[saddlepaddle]

Description

Related Issues

Type of Change

• Bug fix
• New feature
• Documentation
• Refactor
• Other (please describe):

Testing

Screenshots (if applicable)

Additional Notes

Summary by CodeRabbit

• Chores
  • Enhanced setup and teardown scripts with improved error handling and environment variable validation.
  • Added support for database connection pooling configuration.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
website	Ready	Preview	Comment	Dec 1, 2025 10:28pm

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Two shell scripts enhance Neon database integration: setup.sh now parses JSON output from neonctl to extract connection parameters and construct a pooled database URL, persisting additional metadata to .env. teardown.sh loads environment variables and uses the persisted BRANCH_ID for cleanup operations, with added validation and stricter shell error handling across both scripts.

Changes

Cohort / File(s)	Change Summary
Neon setup and metadata persistence .superset/setup.sh	Enhanced shell strictness with set -euo pipefail. Changed neonctl invocation to use --output json and parse JSON response to extract BRANCH_ID, DATABASE_URL, POOLER_HOST, PASSWORD, ROLE, and DATABASE. Constructed new DATABASE_POOLED_URL variable combining parsed parameters. Added NEON_BRANCH_ID persistence to generated .env file.
Neon teardown with environment-driven cleanup .superset/teardown.sh	Enhanced shell strictness with set -euo pipefail. Added .env file sourcing when available. Introduced BRANCH_ID variable derived from NEON_BRANCH_ID with validation guard. Changed neonctl branch deletion to use BRANCH_ID instead of WORKSPACE_NAME. Updated logging messages to reference BRANCH_ID.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

• Shell script enhancements with straightforward JSON parsing and environment variable handling
• Both files follow consistent patterns of strict mode adoption and Neon metadata extraction/usage
• Areas requiring attention:
  • JSON parsing correctness in shell (jq or similar utilities should be verified)
  • Ensure BRANCH_ID validation properly guards against missing environment variables
  • Confirm pooled URL construction syntax is correct for PostgreSQL connection strings

Possibly related PRs

• fix: correct setup and teardown scripts #179: Both modify setup/teardown scripts to parse Neon connection parameters and construct DATABASE_POOLED_URL, with coordination of branch ID handling.
• refactor: move setup/teardown scripts to .superset directory #181: Both modify .superset/setup.sh and .superset/teardown.sh to refactor neonctl branch create/delete invocations and regenerate env variables.
• feat(desktop): add teardown script support for workspace deletion #178: Both introduce/update teardown workflow scripts and Neon branch deletion logic using persisted BRANCH_ID metadata.

Poem

🐰 A rabbit hops through scripts so tight,
With pipefail and JSON in sight,
Pooled connections flow with care,
Branch IDs persist everywhere—
Setup and teardown dance just right!

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch pearl-thunder-58

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fac0d44 and aaa203d.

📒 Files selected for processing (2)

• .superset/setup.sh (3 hunks)
• .superset/teardown.sh (2 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}