Skip to content

refactor: move setup/teardown scripts to .superset directory#181

Merged
saddlepaddle merged 1 commit intomainfrom
fix/setup-teardown-scripts
Nov 29, 2025
Merged

refactor: move setup/teardown scripts to .superset directory#181
saddlepaddle merged 1 commit intomainfrom
fix/setup-teardown-scripts

Conversation

@saddlepaddle
Copy link
Copy Markdown
Collaborator

@saddlepaddle saddlepaddle commented Nov 29, 2025

Summary

  • Move superset-setup.sh to .superset/setup.sh
  • Move superset-teardown.sh to .superset/teardown.sh
  • Update setup.json to reference new paths
  • Update .gitignore to track .superset config and scripts

This keeps all superset workspace config in one place and ensures the scripts are available in every worktree.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features

    • Added teardown script for Superset workspace cleanup.
  • Chores

    • Updated Superset configuration file paths.
    • Modified .gitignore to track setup and teardown scripts while ignoring other workspace files.
    • Simplified setup process to streamline initialization workflow.

✏️ Tip: You can customize this high-level summary in your review settings.

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 29, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
website Ready Ready Preview Comment Nov 29, 2025 6:42am

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Nov 29, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request updates the .superset directory structure and tooling configuration. It refines .gitignore rules to track only three specific files (setup.json, setup.sh, teardown.sh) while ignoring other directory contents, updates setup.json configuration paths, removes a jq dependency check from setup.sh, refactors output capture logic in setup.sh to use direct neonctl calls, and introduces a new teardown.sh script for workspace cleanup.

Changes

Cohort / File(s) Summary
Configuration & Version Control
.gitignore
Updated .superset directory ignore rules to track specific files (setup.json, setup.sh, teardown.sh) instead of ignoring the entire directory
Setup Configuration
.superset/setup.json
Updated script paths from ./superset-setup.sh and ./superset-teardown.sh to .//.superset/setup.sh and .//.superset/teardown.sh
Setup Script
.superset/setup.sh
Removed jq strict dependency check and associated error handling; refactored neonctl output capture to use direct command invocations instead of JSON parsing from stored output
Teardown Script
.superset/teardown.sh
New script providing workspace teardown functionality, validates neonctl installation, resolves workspace name, and deletes corresponding Neon branch with error handling

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • .superset/setup.sh: Review logic changes related to neonctl output handling and jq dependency removal to ensure neonctl cs commands correctly replace JSON parsing
  • .superset/teardown.sh: Verify error handling logic and neonctl branch deletion behavior, particularly for edge cases (branch not found, already deleted)
  • .gitignore: Confirm inclusion/exclusion rules are syntactically correct and achieve intended file tracking behavior

Possibly related PRs

Poem

🐰 A setup and teardown, so neat and so clean,
No more jq troubling our Neon machine,
From parsing JSON to direct calls we go,
One script to start, one to let systems slow,
In dotfiles we whitelist, ignoring the rest,
Our rabbit-built pipelines now pass the test!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: moving setup/teardown scripts to the .superset directory, which is the primary objective of this refactoring PR.
Description check ✅ Passed The PR description covers the main changes and purpose, but lacks details in the template sections like Related Issues, Type of Change checkbox, Testing procedures, and Additional Notes.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 73dd91b and 9eaf75c.

📒 Files selected for processing (2)
  • .gitignore (1 hunks)
  • .superset/setup.json (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

- Move superset-setup.sh to .superset/setup.sh
- Move superset-teardown.sh to .superset/teardown.sh
- Update setup.json to reference new paths
- Update .gitignore to track .superset config and scripts

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@saddlepaddle saddlepaddle force-pushed the fix/setup-teardown-scripts branch from 40f8da6 to 9eaf75c Compare November 29, 2025 06:42
@saddlepaddle saddlepaddle merged commit 05a6348 into main Nov 29, 2025
6 of 7 checks passed
@Kitenite Kitenite deleted the fix/setup-teardown-scripts branch December 1, 2025 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant