Fix teardown to work when no .env passed and no branch

[Kitenite]

Description

Related Issues

Type of Change

• Bug fix
• New feature
• Documentation
• Refactor
• Other (please describe):

Testing

Screenshots (if applicable)

Additional Notes

Summary by CodeRabbit

• Chores
  • Improved environment and resource cleanup process with better error handling and pre-checks to prevent incomplete deletions.

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The .superset/teardown.sh script's error-handling behavior is modified. Missing .env files now trigger a warning but succeed (exit 0) instead of failing. Neon branch deletion now includes a pre-existence check and treats deletion failures as fatal errors, removing prior tolerance for not-found states.

Changes

Cohort / File(s)	Summary
Teardown Script Error Handling .superset/teardown.sh	Modified step_load_env to warn and continue on missing .env instead of failing. Enhanced step_delete_neon_branch with pre-check for branch existence and stricter error handling that now treats deletion failures as fatal (exit 1) rather than non-fatal.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• fix(scripts): improve workspace setup/teardown reliability #333: Reverses the graceful "already deleted" tolerance for Neon branch deletion by making failures fatal, directly modifying the prior approach.
• refactor: modularize setup and teardown scripts for resilience #527: Modifies the same teardown script functions (step_load_env and step_delete_neon_branch) and alters their error-handling and exit-code semantics.
• Fix neon setup/teardown scripts #221: Adjusts Neon branch deletion logic and environment handling within the same teardown script.

Poem

🐰 A script that was lenient, now precise,
Missing configs? No more price!
But branch deletions? Must succeed,
Or fail fast—that's what we need! ✨

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch kitenite/teardown-pt-2

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🚀 Preview Deployment

🔗 Preview Links

Service	Status	Link
Database (Neon)	✅	View Branch
Electric (Fly.io)	✅	View App
API (Vercel)	✅	Open Preview
Web (Vercel)	✅	Open Preview
Marketing (Vercel)	✅	Open Preview
Admin (Vercel)	✅	Open Preview
Docs (Vercel)	✅	Open Preview

---

Preview updates automatically with new commits