Skip to content

Remove session restored popup#1106

Merged
Kitenite merged 2 commits intomainfrom
cake
Feb 1, 2026
Merged

Remove session restored popup#1106
Kitenite merged 2 commits intomainfrom
cake

Conversation

@Kitenite
Copy link
Copy Markdown
Collaborator

@Kitenite Kitenite commented Feb 1, 2026

Description

Related Issues

Type of Change

  • Bug fix
  • New feature
  • Documentation
  • Refactor
  • Other (please describe):

Testing

Screenshots (if applicable)

Additional Notes

Summary by CodeRabbit

  • New Features

    • Terminal now automatically initializes the shell when focus returns to a restored session.
  • Style

    • Refined session restoration status messaging for improved clarity.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 1, 2026

Warning

Rate limit exceeded

@Kitenite has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 11 minutes and 18 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📝 Walkthrough

Walkthrough

The changes refactor terminal restoration handling by removing the RestoredModeOverlay component and replacing it with an effect that automatically starts the shell when the terminal is in restored mode and focused. The separator text displayed during cold restore is updated to "Session Contents Restored".

Changes

Cohort / File(s) Summary
Terminal Restored Mode Behavior
apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/Terminal/Terminal.tsx
Removed RestoredModeOverlay component import and rendering. Added an effect hook that automatically calls handleStartShell when terminal is in restored mode and focused, triggering shell startup without explicit overlay UI.
Cold Restore Messaging
apps/desktop/src/renderer/screens/main/components/WorkspaceView/ContentView/TabsContent/Terminal/hooks/useTerminalColdRestore.ts
Updated separator text from "New session" to "Session Contents Restored" to clarify the nature of the restored session.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 A shell springs forth when restored and keen,
No overlay needed—straight and clean.
Sessions awaken with auto-delight,
"Contents Restored" shines clean and bright!

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description contains only the empty template with no actual content—no description of changes, related issues, type of change selection, testing details, or additional context provided. Fill in the Description section with details about removing the RestoredModeOverlay, explain the rationale, specify the type of change, describe testing performed, and note any related issues.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Remove session restored popup' directly and clearly summarizes the main change: removing the RestoredModeOverlay component and its associated UI rendering.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cake

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Kitenite Kitenite merged commit 7a5ed62 into main Feb 1, 2026
5 checks passed
@Kitenite Kitenite deleted the cake branch February 1, 2026 02:54
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 1, 2026

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ✅ Neon database branch
  • ⚠️ Electric Fly.io app

Thank you for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant