feat (desktop): disable telemetry option in settings#1048
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughThe PR adds telemetry toggle functionality to the desktop application. It introduces a new Changes
Sequence DiagramsequenceDiagram
actor User
participant UI as BehaviorSettings UI
participant TRPC as TRPC Router
participant DB as Database
participant Sync as TelemetrySync
participant PostHog as PostHog
participant Analytics as Analytics Module
User->>UI: Toggle telemetry switch
UI->>UI: Optimistic update
UI->>TRPC: setTelemetryEnabled({ enabled })
TRPC->>DB: Upsert settings.telemetry_enabled
DB-->>TRPC: Success
TRPC-->>UI: { success: true }
UI->>TRPC: Invalidate getTelemetryEnabled
TRPC->>DB: Query telemetry_enabled
DB-->>TRPC: Value
TRPC-->>Sync: Updated state
Sync->>Sync: Effect triggered
alt enabled === true
Sync->>PostHog: posthog.opt_in_capturing()
else enabled === false
Sync->>PostHog: posthog.opt_out_capturing()
end
PostHog-->>Sync: Updated
Analytics->>DB: Check isTelemetryEnabled()
DB-->>Analytics: telemetry_enabled value
alt Telemetry disabled
Analytics->>Analytics: Skip track() execution
else Telemetry enabled
Analytics->>PostHog: Send event
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@apps/desktop/src/main/lib/analytics/index.ts`:
- Around line 26-33: The catch in isTelemetryEnabled silently swallows errors;
update the catch block to log the caught error with context using the prefixed
pattern (e.g. "[analytics/isTelemetryEnabled]") before returning
DEFAULT_TELEMETRY_ENABLED—capture the exception from the failing call to
localDb.select().from(settings).get() and call console.error (or the module's
logger) with a clear message and the error object to ensure errors are surfaced
for debugging.
🧹 Nitpick comments (1)
apps/desktop/src/lib/trpc/routers/settings/index.ts (1)
410-428: Extract the settings row id to a named constant.
id: 1is a magic number; consider a module‑levelSETTINGS_ROW_IDfor clarity and consistency.Based on learnings: Avoid magic numbers by extracting them to named constants at module top.♻️ Suggested refactor
+const SETTINGS_ROW_ID = 1;- .values({ id: 1, telemetryEnabled: input.enabled }) + .values({ id: SETTINGS_ROW_ID, telemetryEnabled: input.enabled })
Comment on lines
+26
to
+33
| function isTelemetryEnabled(): boolean { | ||
| try { | ||
| const row = localDb.select().from(settings).get(); | ||
| return row?.telemetryEnabled ?? DEFAULT_TELEMETRY_ENABLED; | ||
| } catch { | ||
| return DEFAULT_TELEMETRY_ENABLED; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Add error logging in the catch block.
The catch block silently swallows errors without any logging. Per coding guidelines, errors should at minimum be logged with context to aid debugging.
🛡️ Proposed fix to add error logging
function isTelemetryEnabled(): boolean {
try {
const row = localDb.select().from(settings).get();
return row?.telemetryEnabled ?? DEFAULT_TELEMETRY_ENABLED;
- } catch {
+ } catch (error) {
+ console.error("[analytics/telemetry] Failed to read telemetry setting:", error);
return DEFAULT_TELEMETRY_ENABLED;
}
}As per coding guidelines: "Never swallow errors silently; at minimum log them with context" and "Use prefixed console logging with pattern [domain/operation] message for all logging".
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| function isTelemetryEnabled(): boolean { | |
| try { | |
| const row = localDb.select().from(settings).get(); | |
| return row?.telemetryEnabled ?? DEFAULT_TELEMETRY_ENABLED; | |
| } catch { | |
| return DEFAULT_TELEMETRY_ENABLED; | |
| } | |
| } | |
| function isTelemetryEnabled(): boolean { | |
| try { | |
| const row = localDb.select().from(settings).get(); | |
| return row?.telemetryEnabled ?? DEFAULT_TELEMETRY_ENABLED; | |
| } catch (error) { | |
| console.error("[analytics/telemetry] Failed to read telemetry setting:", error); | |
| return DEFAULT_TELEMETRY_ENABLED; | |
| } | |
| } |
🤖 Prompt for AI Agents
In `@apps/desktop/src/main/lib/analytics/index.ts` around lines 26 - 33, The catch
in isTelemetryEnabled silently swallows errors; update the catch block to log
the caught error with context using the prefixed pattern (e.g.
"[analytics/isTelemetryEnabled]") before returning
DEFAULT_TELEMETRY_ENABLED—capture the exception from the failing call to
localDb.select().from(settings).get() and call console.error (or the module's
logger) with a clear message and the error object to ensure errors are surfaced
for debugging.
This was referenced Feb 5, 2026
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Type of Change
Testing
Screenshots (if applicable)
Additional Notes
Summary by CodeRabbit
New Features