Disable telemetry column

[Kitenite]

Description

There's some migration issue with this. This column is now removed and another may be added. Users won't be able to toggle telemetry until then.

Related Issues

Type of Change

• Bug fix
• New feature
• Documentation
• Refactor
• Other (please describe):

Testing

Screenshots (if applicable)

Additional Notes

Summary by CodeRabbit

• Chores
  • Removed telemetry toggle from settings UI; telemetry configuration now controlled by default settings only.
  • Simplified telemetry control flow by eliminating runtime database queries; telemetry state is now determined by default configuration.

[coderabbitai]

📝 Walkthrough

Walkthrough

Removes telemetry runtime configuration by eliminating the database column, simplifying router procedures to return static values, updating analytics to always use default settings, and hiding telemetry UI controls.

Changes

Cohort / File(s)	Summary
Settings Router apps/desktop/src/lib/trpc/routers/settings/index.ts	Removed DEFAULT_TELEMETRY_ENABLED import. getTelemetryEnabled now returns true; setTelemetryEnabled becomes a no-op returning { success: true }. Added TODO comment for cleanup when column is dropped.
Analytics Module apps/desktop/src/main/lib/analytics/index.ts	Removed database queries and settings imports. isTelemetryEnabled() now always returns DEFAULT_TELEMETRY_ENABLED constant instead of reading from DB.
Database Schema packages/local-db/src/schema/schema.ts, packages/local-db/drizzle/0016_add_telemetry_enabled.sql	Removed telemetryEnabled column from settings table. Migration script converted to no-op with SELECT 1 statement.
Settings UI apps/desktop/src/renderer/routes/_authenticated/settings/behavior/components/BehaviorSettings/BehaviorSettings.tsx	Hidden telemetry section by changing render condition to {false && ...}. Fully defined mutation handlers. Added TODO for cleanup.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• feat (desktop): disable telemetry option in settings #1048: This PR reverses and removes the telemetry-related additions from #1048, undoing the same settings router, analytics, database schema, and UI changes.

Poem

Hop along, telemetry friends,
Our config story ends,
Back to defaults we go,
🐰 The schema's light glow,
Simpler states, the path that mends!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Disable telemetry column' is concise and directly reflects the main change: disabling/removing the telemetry_enabled column from the database schema and related functionality.
Description check	✅ Passed	The PR description provides a brief explanation of the migration issue and its impact, but omits several template sections including Related Issues, Type of Change, Testing, and Additional Notes.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch kitenite/onion

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🚀 Preview Deployment

🔗 Preview Links

Service	Status	Link
Database (Neon)	✅	View Branch
Electric (Fly.io)	✅	View App
API (Vercel)	✅	Open Preview
Web (Vercel)	✅	Open Preview
Marketing (Vercel)	✅	Open Preview
Admin (Vercel)	✅	Open Preview
Docs (Vercel)	✅	Open Preview

---

Preview updates automatically with new commits