feat(desktop): add toggleable preset bar below tab strip#1430
Merged
Conversation
Add a persistent horizontal bar that shows all terminal presets with their icons and names, similar to a bookmarks bar. Users can toggle visibility via a checkbox in the terminal dropdown menu. The setting is persisted across sessions via the local database.
Contributor
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThis pull request adds a user-preference feature to toggle the visibility of a presets bar in the workspace. The implementation spans database schema changes (new Changes
Sequence DiagramsequenceDiagram
actor User
participant GroupStrip as GroupStrip<br/>(UI)
participant TRPC as TRPC Client<br/>(electronTrpc)
participant Backend as Settings Router<br/>(Backend)
participant DB as Database
participant ContentView as ContentView<br/>(UI)
participant PresetsBar as PresetsBar<br/>(Component)
User->>GroupStrip: Click "Show Preset Bar" checkbox
GroupStrip->>GroupStrip: Optimistic update cache
GroupStrip->>TRPC: setShowPresetsBar(enabled: boolean)
TRPC->>Backend: Send mutation request
Backend->>DB: Upsert settings.show_presets_bar
DB-->>Backend: Update confirmed
Backend-->>TRPC: Return { success: true }
TRPC->>TRPC: Invalidate cache on settle
ContentView->>TRPC: getShowPresetsBar.useQuery()
TRPC->>Backend: Fetch current showPresetsBar
Backend->>DB: SELECT showPresetsBar
DB-->>Backend: Return value (or default)
Backend-->>TRPC: Return boolean
TRPC-->>ContentView: Update query data
alt showPresetsBar is true
ContentView->>PresetsBar: Render component
PresetsBar-->>User: Display preset items
else showPresetsBar is false
ContentView->>ContentView: Skip PresetsBar render
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🚀 Preview Deployment🔗 Preview Links
Preview updates automatically with new commits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Schema & Migration
showPresetsBarboolean column tosettingstable (packages/local-db)0023_add_show_presets_bar_settingBackend (tRPC)
getShowPresetsBar/setShowPresetsBarprocedures following existingconfirmOnQuitpatternDEFAULT_SHOW_PRESETS_BAR = falseconstantFrontend
DropdownMenuCheckboxItemtoggle ("Show Preset Bar") in GroupStrip dropdown with optimistic mutationPresetsBarcomponent — horizontal bar with ghost buttons per preset (icon + name), tooltips for descriptionsPresetsBarinContentViewbetween header and tab contentTest Plan
Summary by CodeRabbit