Skip to content

Prepare for new testnets#507

Merged
hellwolf merged 49 commits intodevfrom
prepare_new_testnets
Dec 9, 2021
Merged

Prepare for new testnets#507
hellwolf merged 49 commits intodevfrom
prepare_new_testnets

Conversation

@hellwolf
Copy link
Contributor

@hellwolf hellwolf commented Nov 24, 2021

  • New resolver using 2470 method
    • 0xce0042B868300000d44A59004Da54A005ffdcf9f
    • salt?
  • Refactor truffle config: network alias and usage of HDWalletProvider
  • Missing events

return {
provider: () =>
new HDWalletProvider({
mnemonic: getEnvValue(networkName, "MNEMONIC"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this change breaks configs using private keys with truffle.
The legacy initialization method accepted both passphrase or private key as first argument. With the new way, the field privateKeys needs to be set for PKs.

Copy link
Contributor Author

@hellwolf hellwolf Nov 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you using the privateKey initialization method?

can you show an example?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently I just assign the PK to the mnemonic var, e.g. XDAI_MNEMONIC=123....
That works with the legacy way of initializing HDWalletProvider, bcs the first argument could be mnemonic, pk, or pk array.

@hellwolf hellwolf mentioned this pull request Nov 25, 2021
4 tasks
@hellwolf
Copy link
Contributor Author

hellwolf commented Nov 26, 2021

Related to deterministic resolver address for future deployment: to save Resolver build artifacts for future:

cat build/contracts/Resolver.json |  jq -cr '{ abi: .abi, bin: .bytecode}'

@hellwolf hellwolf marked this pull request as ready for review November 26, 2021 12:22
@hellwolf hellwolf marked this pull request as draft November 26, 2021 12:22
@github-actions
Copy link

📦 PR Packages

Install this PR (you need to setup Github packages):

yarn add @superfluid-finance/js-sdk@PR507
yarn add @superfluid-finance/ethereum-contracts@PR507
yarn add @superfluid-finance/sdk-core@PR507
:octocat: Click to learn how to use Github packages

To use the Github package registry, create a token with "read:packages" permission. See Creating a personal access token for help.

Next add these lines to your .npmrc file, replacing TOKEN with your personal access token. See Installing a package from Github if you get stuck.

@superfluid-finance:registry=https://npm.pkg.github.com
//npm.pkg.github.com/:_authToken=TOKEN

@hellwolf
Copy link
Contributor Author

Current blocker for optimism: ethereum-optimism/optimism#1720

@hellwolf hellwolf linked an issue Dec 6, 2021 that may be closed by this pull request
5 tasks
@hellwolf
Copy link
Contributor Author

hellwolf commented Dec 6, 2021

  • Create new Resolvers for new testnets and mainnets
  • Change existing resolvers' admin to ltd admin
  • Deploy framework and test tokens to new testnets

@d10r d10r force-pushed the prepare_new_testnets branch from d16af62 to 620963b Compare December 7, 2021 09:19
hellwolf and others added 27 commits December 7, 2021 17:49
TODO: Arb-mainnet, AVAX, OP-main
- fuji => avalanche-fuji because of subgraph name
- new OPKovan addresses in config + `addresses.template.ts`
- somewhat hacky solution for passing tests
- will need to refactor tests to be more robust (changing initial token amount doesn't break the tests)
@hellwolf hellwolf marked this pull request as ready for review December 9, 2021 10:19
@hellwolf hellwolf merged commit bc1d5ba into dev Dec 9, 2021
@hellwolf hellwolf deleted the prepare_new_testnets branch December 9, 2021 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ETHEREUM-CONTRACTS] Upgrade resolver and migrate existing entries

3 participants