Conversation
| return { | ||
| provider: () => | ||
| new HDWalletProvider({ | ||
| mnemonic: getEnvValue(networkName, "MNEMONIC"), |
There was a problem hiding this comment.
Note that this change breaks configs using private keys with truffle.
The legacy initialization method accepted both passphrase or private key as first argument. With the new way, the field privateKeys needs to be set for PKs.
There was a problem hiding this comment.
are you using the privateKey initialization method?
can you show an example?
There was a problem hiding this comment.
Currently I just assign the PK to the mnemonic var, e.g. XDAI_MNEMONIC=123....
That works with the legacy way of initializing HDWalletProvider, bcs the first argument could be mnemonic, pk, or pk array.
- TestResolver => Resolver
|
Related to deterministic resolver address for future deployment: to save Resolver build artifacts for future: |
📦 PR PackagesInstall this PR (you need to setup Github packages): yarn add @superfluid-finance/js-sdk@PR507
yarn add @superfluid-finance/ethereum-contracts@PR507
yarn add @superfluid-finance/sdk-core@PR507
|
|
Current blocker for optimism: ethereum-optimism/optimism#1720 |
|
d16af62 to
620963b
Compare
This reverts commit 620963b.
TODO: Arb-mainnet, AVAX, OP-main
…protocol-monorepo into prepare_new_testnets
Missing events