Conversation
|
@hellwolf rename to just Resolver? Or SuperfluidResolver? Or ... ? |
d726989 to
b2b5bcf
Compare
|
The last commit also affects the external interface as it renames env vars. Not sure if we can/should do that without keeping backwards compatibility to the previously used names at least for a while. |
b2b5bcf to
f11e205
Compare
📦 PR PackagesInstall this PR (you need to setup Github packages): yarn add @superfluid-finance/js-sdk@PR419
yarn add @superfluid-finance/ethereum-contracts@PR419
|
|
deployed to goerli using that deterministic deployment proxy: which led to a successful deployment of the Resolver at https://goerli.etherscan.io/address/0x7bdb7cc80ca59bba3b74e2d7cd544d5595ac3d97 Trying to deploy the same bytecode a 2nd time through that proxy causes a revert. The deployer seems to exist on all testnets and mainnets currently relevant for us. |
@d10r We could create a scripts/deploy-erc1820.js (which uses pre-built artifacts/ERC1820Registry.json) counter part for resolver, and have its own prebuit artifacts/Resolver.json. As long as we consider our resolver implementation is stable enough, we could pull the trigger. |
|
I stole everything to #507 |
ux(fromtest)