Skip to content

Upgrade Resolver#419

Closed
d10r wants to merge 5 commits intodevfrom
resolver_update
Closed

Upgrade Resolver#419
d10r wants to merge 5 commits intodevfrom
resolver_update

Conversation

@d10r
Copy link
Collaborator

@d10r d10r commented Sep 13, 2021

  • add Set event
  • rename from TestResolver to ?
  • move to directory ux (from test)
  • deploy to same address on all networks (e.g. using this)

@d10r d10r self-assigned this Sep 13, 2021
@d10r
Copy link
Collaborator Author

d10r commented Sep 13, 2021

@hellwolf rename to just Resolver? Or SuperfluidResolver? Or ... ?

@d10r
Copy link
Collaborator Author

d10r commented Sep 13, 2021

The last commit also affects the external interface as it renames env vars. Not sure if we can/should do that without keeping backwards compatibility to the previously used names at least for a while.

@github-actions
Copy link

📦 PR Packages

Install this PR (you need to setup Github packages):

yarn add @superfluid-finance/js-sdk@PR419
yarn add @superfluid-finance/ethereum-contracts@PR419
:octocat: Click to learn how to use Github packages

To use the Github package registry, create a token with "read:packages" permission. See Creating a personal access token for help.

Next add these lines to your .npmrc file, replacing TOKEN with your personal access token. See Installing a package from Github if you get stuck.

@superfluid-finance:registry=https://npm.pkg.github.com
//npm.pkg.github.com/:_authToken=TOKEN

@d10r
Copy link
Collaborator Author

d10r commented Sep 13, 2021

deployed to goerli using that deterministic deployment proxy:

truffle(goerli)> web3.eth.sendTransaction({from: sender, to: "0x7A0D94F55792C434d74a40883C6ed8545E406D12", data: Resolver.binary})

which led to a successful deployment of the Resolver at https://goerli.etherscan.io/address/0x7bdb7cc80ca59bba3b74e2d7cd544d5595ac3d97

Trying to deploy the same bytecode a 2nd time through that proxy causes a revert.

The deployer seems to exist on all testnets and mainnets currently relevant for us.

@d10r d10r requested a review from hellwolf September 14, 2021 06:57
@hellwolf
Copy link
Contributor

deploy to same address on all networks (e.g. using this)

@d10r We could create a scripts/deploy-erc1820.js (which uses pre-built artifacts/ERC1820Registry.json) counter part for resolver, and have its own prebuit artifacts/Resolver.json. As long as we consider our resolver implementation is stable enough, we could pull the trigger.

@hellwolf hellwolf linked an issue Sep 30, 2021 that may be closed by this pull request
5 tasks
@hellwolf hellwolf changed the title Prepare Resolver for update Upgrade Resolver Nov 12, 2021
@hellwolf
Copy link
Contributor

I stole everything to #507

@hellwolf hellwolf closed this Nov 25, 2021
@hellwolf hellwolf deleted the resolver_update branch December 10, 2021 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ETHEREUM-CONTRACTS] Upgrade resolver and migrate existing entries

2 participants