Conversation
🦋 Changeset detectedLatest commit: 6bd6768 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
2-reviewers
A-integration
|
This PR will also need an update to the DTL |
Added in e84114d |
Codecov Report
@@ Coverage Diff @@
## develop #1720 +/- ##
===========================================
- Coverage 72.00% 71.99% -0.01%
===========================================
Files 70 70
Lines 2318 2321 +3
Branches 345 346 +1
===========================================
+ Hits 1669 1671 +2
- Misses 649 650 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
tynes
force-pushed
the
feat/allow-unprotected-txs
branch
from
e84114d to
e579cf2
Compare
|
e579cf2 adds test coverage for replicas, it enables the replica in the integration tests which adds a bit of additional load to the machine that has to run the integration tests |
tynes
force-pushed
the
feat/allow-unprotected-txs
branch
3 times, most recently
from
65cd247 to
2232368
Compare
|
Actually there are failing integration tests that need to be solved first |
smartcontracts
left a comment
smartcontracts
left a comment
There was a problem hiding this comment.
Blocking merge of this PR pending additional tests, will have to wait until after upgrade
smartcontracts
force-pushed
the
regenesis/0.5.0
branch
from
d7dddc6 to
2049794
Compare
smartcontracts
force-pushed
the
feat/allow-unprotected-txs
branch
from
2232368 to
f541767
Compare
tynes
force-pushed
the
feat/allow-unprotected-txs
branch
3 times, most recently
from
2f246ac to
1900e61
Compare
This comment has been minimized.
This comment has been minimized.
The old transaction batch serialization assumed that the correct chain id was used as there was a custom transaction serialization used. Now that the full RLP of the transactions are submitted to L1 for availability, it is possible to enable non EIP155 transactions. This allows for universal addresses to be used, where the same address exists across many chains. A test is updated to test specifically that transactions that are not protected with a chain id can be submitted and accepted by the sequencer.
When syncing from L2, all transactions were assumed to be protected. To prevent a network split for replicas, the DTL needs to check for transactions that are not protected and handle parsing the `v` parameter appropriately.
tynes
force-pushed
the
feat/allow-unprotected-txs
branch
from
c484d5a to
300683c
Compare
tynes
force-pushed
the
feat/allow-unprotected-txs
branch
from
fe6a757 to
6bd6768
Compare
|
Great! how could we utilize this to deploy the 1820 contract? https://kovan-optimistic.etherscan.io/address/0x1820a4B7618BdE71Dce8cdc73aAB6C95905faD24 |
5 participants
Description
The old transaction batch serialization assumed that the
correct chain id was used as there was a custom transaction
serialization used. Now that the full RLP of the transactions
are submitted to L1 for availability, it is possible to enable
non EIP155 transactions. This allows for universal addresses
to be used, where the same address exists across many chains.
A test is updated to test specifically that transactions that
are not protected with a chain id can be submitted and accepted
by the sequencer.
Fixes ENG-1680