Fixes a crash when using a defaultProp that is not listed in props #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, thanks! |
sapegin
pushed a commit
that referenced
this pull request
May 12, 2017
sapegin
added a commit
that referenced
this pull request
Jun 8, 2017
## New features ### UI refresh Welcome our refined UI! More consistent and clean:  🦊 This is the first part of the planned improvements and a base for upcoming plugin API, see #426 and #354 for more details — we need your feedback there 🚀 🍕 Thanks to @SaraVieira and @n1313 for help! ❤️ ### Props & methods are hidden by default Use the new config option [showUsage](https://react-styleguidist.js.org/docs/configuration.html#showusage) to restore the old behavior. ## Bug fixes ### Crash when using a defaultProp that is not listed in props (#437 by @ankri) ### Isolated examples inside sections ### Issues with `position: relative` (#441) ### Ugly isolated example link (#235)
sapegin
added a commit
that referenced
this pull request
Jun 8, 2017
## New features ### UI refresh Welcome our refined UI! More consistent and clean:  🦊 This is the first part of the planned improvements and a base for upcoming plugin API, see #426 and #354 for more details — we need your feedback there 🚀 🍕 Thanks to @SaraVieira and @n1313 for help! ❤️ ### Props & methods are hidden by default Use the new config option [showUsage](https://react-styleguidist.js.org/docs/configuration.html#showusage) to restore the old behavior. ## Bug fixes ### Crash when using a defaultProp that is not listed in props (#437 by @ankri) ### Isolated examples inside sections ### Issues with `position: relative` (#441) ### Ugly isolated example link (#235)
This was referenced Nov 5, 2022
This was referenced Dec 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a crash, that occurs when you use a defaultProp that is not listed in the props. The cause was my previous PR not checking whether the incoming description might be
undefined.The error is kind of nasty because the styleguidist wont compile.
I added the fix and the test to replicate the error.