Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a crash when using a defaultProp that is not listed in props #437

Merged
merged 2 commits into from
May 10, 2017

Conversation

ankri
Copy link
Collaborator

@ankri ankri commented May 10, 2017

This pull request fixes a crash, that occurs when you use a defaultProp that is not listed in the props. The cause was my previous PR not checking whether the incoming description might be undefined.

The error is kind of nasty because the styleguidist wont compile.

I added the fix and the test to replicate the error.

@sapegin
Copy link
Member

sapegin commented May 10, 2017

Cool, thanks!

sapegin added a commit that referenced this pull request Jun 8, 2017
## New features

### UI refresh

Welcome our refined UI! More consistent and clean:

![](https://d3vv6lp55qjaqc.cloudfront.net/items/3j1P0K1a1Q451t2Z2p3G/Screen%20Recording%202017-06-08%20at%2008.54%20PM.gif)

🦊 This is the first part of the planned improvements and a base for upcoming plugin API, see #426 and #354 for more details — we need your feedback there 🚀

🍕 Thanks to @SaraVieira and @n1313 for help! ❤️

### Props & methods are hidden by default

Use the new config option [showUsage](https://react-styleguidist.js.org/docs/configuration.html#showusage) to restore the old behavior.

## Bug fixes

### Crash when using a defaultProp that is not listed in props (#437 by @ankri)

### Isolated examples inside sections

### Issues with `position: relative` (#441)

### Ugly isolated example link (#235)
sapegin added a commit that referenced this pull request Jun 8, 2017
## New features

### UI refresh

Welcome our refined UI! More consistent and clean:

![](https://d3vv6lp55qjaqc.cloudfront.net/items/3j1P0K1a1Q451t2Z2p3G/Screen%20Recording%202017-06-08%20at%2008.54%20PM.gif)

🦊 This is the first part of the planned improvements and a base for upcoming plugin API, see #426 and #354 for more details — we need your feedback there 🚀

🍕 Thanks to @SaraVieira and @n1313 for help! ❤️

### Props & methods are hidden by default

Use the new config option [showUsage](https://react-styleguidist.js.org/docs/configuration.html#showusage) to restore the old behavior.

## Bug fixes

### Crash when using a defaultProp that is not listed in props (#437 by @ankri)

### Isolated examples inside sections

### Issues with `position: relative` (#441)

### Ugly isolated example link (#235)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants