-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI improvements proposal (UI 2.0) #426
Comments
Call me biased but I think that current UI is alright and with exception of #350 I don't see any obvious places that need improvement. Ease of access to information, speed and responsiveness of the application and code parsing features like JSDoc support play a much bigger role on the developer experience than UI bells and whistles, in my opinion. As for extensions and plugins, those are probably cool to have but are not related to UI, apart from the question of "where do we put all this new stuff" which I would say should be asked only after we do have that new stuff. |
These are not bells and whistles, these things are required for the plugin API, not something that we can do after that. There are needed as well for almost any new feature that requires a new UI (some of them are listed in the issue). And we already have issues like #235 that cannot be solved by just moving links around. Plugin API has a very high priority because the more users we have the more features they want and less likely I’d want to have all these features in the core. |
From a usability perspective, having an always visible but unobstructive toolbar is in my opinion superior to links that appear on hover. I like and support the idea. P.S. The specific icons are not the best :) |
@Knorcedger I hate these links ;-) Icons are just to show the idea, from Font Awesome. Any better candidates? There’s the whole list of actions in the issue description (some of them are new like toggling props (I really want this) :–) |
I love the current UI, and I agree icons would make it more scalable. |
@sapegin Icons sound like a great idea. By toggling the props you mean that the user would be able to collapse the props ? |
@SaraVieira Yes, because you don’t need them when you’re developing a component. And for some components they occupy a lot of space. |
@MicheleBertoli I mostly like it too except these ugly isolation mode links ;-) |
@SaraVieira Yeah, exactly 😬 It will be a small fix as soon as we implement a global toolbar where we could put that switch — do you want to help with that too? 😊 |
@sapegin Sure, tell me where to start 👍 |
I think we can start from simple things like components for toolbar, toolbar button and global toolbar itself (I think it should be fixed in the bottom left corner inside the sidebar if we have a sidebar or just floating). |
What will be the links there ? |
These are all I can imagine:
So we can start from home and then add props toggle. |
Sure, I'll start by adding the buttons to go home and create a nifty
animation for the sidebar and I can also pick up the individual dropdown of
the props and then we can talk about the better way to do the all props
dropdown.
Should we put the new logo on the header?
…On Fri, 5 May 2017, 09:58 Artem Sapegin, ***@***.***> wrote:
These are all I can imagine:
- Global (toggle sidebar, toggle props/description, switch background,
close isolation = go home);
So we can start from home and then add props toggle.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#426 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABALdY0RH0kpSu3-WX-zYe07ZR6lFfbaks5r2uTNgaJpZM4NPU0w>
.
|
What do you mean by “dropdown of the props”? ;-) I’m not sure about the logo because the text can be changed but would be nice to have it somewhere. |
@cef62 @SaraVieira The new toolbar is in the |
I think the "link" icon should be connected with the heading. I really like how GitHub shows them. Do you think we still could show them together? |
@okonet We can make header a simple link but I don’t want to show anything on the left side, it didn’t really work for Styleguidist (can be hidden on small screens, having something on both sides of the header was strange). |
Thing I know I’m going to change:
|
@sapegin how does it look on small screens? we used to hide sidebar and props for small screens |
and make preview container as wide as possible |
No changes for small screens so far bug I should test it again ;-)
What do you mean? Remove |
i checked it now, nvm preview component seems good |
## New features ### UI refresh Welcome our refined UI! More consistent and clean: ![](https://d3vv6lp55qjaqc.cloudfront.net/items/3j1P0K1a1Q451t2Z2p3G/Screen%20Recording%202017-06-08%20at%2008.54%20PM.gif) 🦊 This is the first part of the planned improvements and a base for upcoming plugin API, see #426 and #354 for more details — we need your feedback there 🚀 🍕 Thanks to @SaraVieira and @n1313 for help! ❤️ ### Props & methods are hidden by default Use the new config option [showUsage](https://react-styleguidist.js.org/docs/configuration.html#showusage) to restore the old behavior. ## Bug fixes ### Crash when using a defaultProp that is not listed in props (#437 by @ankri) ### Isolated examples inside sections ### Issues with `position: relative` (#441) ### Ugly isolated example link (#235)
## New features ### UI refresh Welcome our refined UI! More consistent and clean: ![](https://d3vv6lp55qjaqc.cloudfront.net/items/3j1P0K1a1Q451t2Z2p3G/Screen%20Recording%202017-06-08%20at%2008.54%20PM.gif) 🦊 This is the first part of the planned improvements and a base for upcoming plugin API, see #426 and #354 for more details — we need your feedback there 🚀 🍕 Thanks to @SaraVieira and @n1313 for help! ❤️ ### Props & methods are hidden by default Use the new config option [showUsage](https://react-styleguidist.js.org/docs/configuration.html#showusage) to restore the old behavior. ## Bug fixes ### Crash when using a defaultProp that is not listed in props (#437 by @ankri) ### Isolated examples inside sections ### Issues with `position: relative` (#441) ### Ugly isolated example link (#235)
The first part is done in 5.4.0! 🦆 |
@sapegin its very nice |
I think it would be great to add a carat icon or something like that on the Props & Methods link, and possible also the Code button, to indicate more clearly that clicking it will expand more information. I like keeping them hidden (as noted earlier, this list can get long), but it's very important information and I think the link may be too easy to overlook as it appears right now. Adding something like an icon would at least indicate that the link will do something more without having to hover to notice that it's link. |
@okonet @SaraVieira What do you think? (See the previous comment ;-) |
😴 This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week without any further activity. Thank you for your contributions. |
We keep adding new function and new “buttons” to the UI and right now it’s inconsistent and far from perfect. Adding more features (and there are plans and wishes to do that) will most likely destroy user experience completely. I was thinking about that for a long time and here are my thoughts.
Goals I want to solve in this issue:
Styleguidist UI consists of these three “levels” (and actions you can do on each level, with some future plans):
As a possible solution I see something like this:
Sorry for my drawing skills but basically we’ll have toolbars for each “level” that could be possible to extend from plugins plus (also extendable) tab bar for each example (this was already discussed in a relation to the plugin API).
Related issues: #354, #333, #327, #424, #421, #235.
Any feedback? Some design help would be very useful here ;-)
The text was updated successfully, but these errors were encountered: