Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

position: relative causes component position to be wrong #441

Closed
magicmark opened this issue May 15, 2017 · 2 comments
Closed

position: relative causes component position to be wrong #441

magicmark opened this issue May 15, 2017 · 2 comments
Labels
Milestone

Comments

@magicmark
Copy link
Contributor

magicmark commented May 15, 2017

Hi, thanks for this awesome project!

I'm writing a hovercard component that uses absolute positioning. When rendering it in a styleguidist example, the component breaks, because it takes its initial position values from a parent div with position: relative specified. (http://i.imgur.com/Q4iwmIT.png)

Any suggestions as to how to get around this? Thanks again!

(To give more context, here's what it looks like 'broken': http://i.imgur.com/UCwxeKd.png. You can see the offset is being calculated from the parent div, rather than the body as expected.)

@sapegin sapegin added the bug label May 15, 2017
@sapegin
Copy link
Member

sapegin commented May 15, 2017

I think we could get rid of position: relative as soon as we finish #426.

@sapegin sapegin added this to the UI 2.0 milestone May 17, 2017
sapegin added a commit that referenced this issue Jun 8, 2017
## New features

### UI refresh

Welcome our refined UI! More consistent and clean:

![](https://d3vv6lp55qjaqc.cloudfront.net/items/3j1P0K1a1Q451t2Z2p3G/Screen%20Recording%202017-06-08%20at%2008.54%20PM.gif)

🦊 This is the first part of the planned improvements and a base for upcoming plugin API, see #426 and #354 for more details — we need your feedback there 🚀

🍕 Thanks to @SaraVieira and @n1313 for help! ❤️

### Props & methods are hidden by default

Use the new config option [showUsage](https://react-styleguidist.js.org/docs/configuration.html#showusage) to restore the old behavior.

## Bug fixes

### Crash when using a defaultProp that is not listed in props (#437 by @ankri)

### Isolated examples inside sections

### Issues with `position: relative` (#441)

### Ugly isolated example link (#235)
sapegin added a commit that referenced this issue Jun 8, 2017
## New features

### UI refresh

Welcome our refined UI! More consistent and clean:

![](https://d3vv6lp55qjaqc.cloudfront.net/items/3j1P0K1a1Q451t2Z2p3G/Screen%20Recording%202017-06-08%20at%2008.54%20PM.gif)

🦊 This is the first part of the planned improvements and a base for upcoming plugin API, see #426 and #354 for more details — we need your feedback there 🚀

🍕 Thanks to @SaraVieira and @n1313 for help! ❤️

### Props & methods are hidden by default

Use the new config option [showUsage](https://react-styleguidist.js.org/docs/configuration.html#showusage) to restore the old behavior.

## Bug fixes

### Crash when using a defaultProp that is not listed in props (#437 by @ankri)

### Isolated examples inside sections

### Issues with `position: relative` (#441)

### Ugly isolated example link (#235)
@sapegin
Copy link
Member

sapegin commented Jun 8, 2017

Should be fixed in 5.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants