Typescript 4.1.2 fails with "Cannot find name 'PositionError'"

[syabro]

What is the current behavior?
I've got an error

node_modules/react-use/lib/useGeolocation.d.ts(11,21): error TS2304: Cannot find name 'PositionError'.

react-use: 15.3.4
typescript: 4.1.2

[dovidweisz]

I'm running into the same issue.

My node_modules folder is listed in my tsconfig excludes

I also tied adding:

node_modules
node_modules/react-use
node_modules/react-use/lib/useGeolocation.d.ts

still failing

[dovidweisz]

I just wonder if maybe this is an issue with TypeScript and not with the types.

[dovidweisz]

It seems like PositionError was changed to GeolocationPositionError in this version of Typescript.

[dovidweisz]

The fix itself is easy, and I would gladly do a PR for it. The issue is backwards compatibility with older versions of Typescript.

I did a little research and there doesn't seem to be a good solution to this problem.

For the time being i created a patch and am running it postinstall.

Here's the patch (it's not that pretty, but it should work):
https://gist.github.com/dovidweisz/4d76168339db89cf05e1090a84b7ee41

Never mind the patch. @ileonovdima 's idea is much better.

[giogonzo]

@dovidweisz typesVersions could help here?

[ileonovdima]

solved the problem by adding in global.d.ts

type PositionError = GeolocationPositionError;

[dovidweisz]

@dovidweisz typesVersions could help here?

@giogonzo: Cool, I didn't know that was available. (I wonder how it would be implemented)

solved the problem by adding in global.d.ts

type PositionError = GeolocationPositionError;

@ileonovdima: Super cool TYVM

I love the way I have that "Contributor" badge here. I literally changed a few characters... Once... IN THE DOCS.

LOL

[giogonzo]

@dovidweisz basically producing 2 different outputs (e.g. one in lib and one in lib4.1) and applying your patch only on lib4.1 (and pointing TS to the correct folder via that key in package.json)

[dovidweisz]

@dovidweisz basically producing 2 different outputs (e.g. one in lib and one in lib4.1) and applying your patch only on lib4.1 (and pointing TS to the correct folder via that key in package.json)

Hmmmm

Seems doable, but I would flip that around. I would:

1. Upgrade the library to the latest version of Typescript.
2. Add a build step that copies the d.ts into a ts4.0 directory, and...
3. Applies the reverse of my patch with a simple string replacement (src.replace("GeolocationPositionError", "PositionError")) to the original files.

I'm looking for other projects with the same (or similar) issues. I guess any front end project that is built in Typescript, and uses typesVersions.

[giogonzo]

Seems doable, but I would flip that around

I agree 👍

[ranisalt]

solved the problem by adding in global.d.ts

Where should this file go? I tried several places and typescript doesn't seem to pick it up.

[ValentinH]

solved the problem by adding in global.d.ts

Where should this file go? I tried several places and typescript doesn't seem to pick it up.

Same here

[dovidweisz]

I have it working, it's in my /sec file.

…

On Fri, Dec 11, 2020, 11:12 AM Valentin Hervieu ***@***.***> wrote: solved the problem by adding in global.d.ts Where should this file go? I tried several places and typescript doesn't seem to pick it up. Same here — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1646 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABUTPCNJEJ54PA4VSKUITOTSUJAFHANCNFSM4T4P6NRA> .

[cliffordfajardo]

I'm also getting this with typescript v4.1.3

[xobotyi]

@dovidweisz made a bit overkill the easiest way is to introduce own interface compatible with GeolocationPositionError

[streamich]

🎉 This issue has been resolved in version 15.3.7 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀