Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #1646 #1738

Merged
merged 1 commit into from
Jan 8, 2021
Merged

fix: #1646 #1738

merged 1 commit into from
Jan 8, 2021

Conversation

xobotyi
Copy link
Contributor

@xobotyi xobotyi commented Jan 8, 2021

Description

Typescript 4.1 has PositionError renamed to GeolocationPositionError and it caused errors

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as before)

Checklist

  • Read the Contributing Guide
  • Perform a code self-review
  • Comment the code, particularly in hard-to-understand areas
  • Add documentation
  • Add hook's story at Storybook
  • Cover changes with tests
  • Ensure the test suite passes (yarn test)
  • Provide 100% tests coverage
  • Make sure code lints (yarn lint). Fix it with yarn lint:fix in case of failure.
  • Make sure types are fine (yarn lint:types).

@xobotyi
fix: #1646
ebc7094 
make own interface that compatible with GeolocationPositionError and PositionError.

It is the easiest way to avoid errors in typescript 4.1
@xobotyi xobotyi merged commit 5d5bcc8 into master Jan 8, 2021
@xobotyi xobotyi deleted the fix-1646 branch January 8, 2021 18:54
@streamich
Copy link
Owner

🎉 This PR is included in version 15.3.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xobotyi @streamich