Skip to content

fix: address sync review feedback for verify followups - #1911

Closed
stranske wants to merge 1 commit into
mainfrom
sync-review-931-fixes
Closed

fix: address sync review feedback for verify followups#1911
stranske wants to merge 1 commit into
mainfrom
sync-review-931-fixes

Conversation

@stranske

@stranske stranske commented Apr 26, 2026

Copy link
Copy Markdown
Owner

Summary

  • Pins agents-verify-to-new-pr.yml action references back to the vetted commit SHAs in both the source workflow and consumer template.
  • Caps stored parse-error details in weekly metrics aggregation with an overflow sentinel instead of appending distinct overflow entries past the limit.
  • Keeps the synced consumer script copy aligned with the source script.

Validation

  • pytest tests/scripts/test_aggregate_agent_metrics.py -q
  • pytest tests/workflows/test_workflow_agents_consolidation.py tests/workflows/test_github_api_retry_standard.py -q
  • python scripts/validate_workflow_yaml.py .github/workflows/agents-verify-to-new-pr.yml templates/consumer-repo/.github/workflows/agents-verify-to-new-pr.yml
  • python scripts/validate_template_sync.py
  • git diff --check

Related consumer sync review: stranske/Travel-Plan-Permission#931

Copilot AI review requested due to automatic review settings April 26, 2026 18:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the agent metrics aggregation script and verification follow-up workflow to incorporate recent review feedback, improving parse-error detail handling and tightening workflow supply-chain hygiene.

Changes:

  • Cap stored parse error details strictly at the configured limit by compacting overflow into a single sentinel “detail-limit-exceeded” entry.
  • Update and add tests to validate overflow compaction/counting behavior.
  • Pin GitHub Actions used by agents-verify-to-new-pr.yml to specific commit SHAs (in both source and consumer template), plus minor script formatting.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/scripts/test_aggregate_agent_metrics.py Adjusts legacy JSON fallback buffer assertions and adds a new test for distinct overflow compaction.
scripts/aggregate_agent_metrics.py Implements strict parse-error detail capping with an explicit overflow sentinel entry.
templates/consumer-repo/scripts/aggregate_agent_metrics.py Mirrors the same parse-error capping changes for consumer template sync.
.github/workflows/agents-verify-to-new-pr.yml Pins external actions by SHA and applies small readability tweaks inside github-script blocks.
templates/consumer-repo/.github/workflows/agents-verify-to-new-pr.yml Mirrors the pinned-action and formatting changes for consumer template sync.

@stranske

Copy link
Copy Markdown
Owner Author

Closing as superseded by #1910. The source fixes from this PR were covered by the merged #1909/#1910 path, and this branch is now stale against main: merging it would drop later Health 68, GitNexus, and aggregate overflow hardening already present on ffb5480. The refreshed campaign run 24963833320 reports 0 actionable/claimable local Codex items for #1836.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants