fix: address sync review feedback for verify followups - #1911
Closed
stranske wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the agent metrics aggregation script and verification follow-up workflow to incorporate recent review feedback, improving parse-error detail handling and tightening workflow supply-chain hygiene.
Changes:
- Cap stored parse error details strictly at the configured limit by compacting overflow into a single sentinel “detail-limit-exceeded” entry.
- Update and add tests to validate overflow compaction/counting behavior.
- Pin GitHub Actions used by
agents-verify-to-new-pr.ymlto specific commit SHAs (in both source and consumer template), plus minor script formatting.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/scripts/test_aggregate_agent_metrics.py | Adjusts legacy JSON fallback buffer assertions and adds a new test for distinct overflow compaction. |
| scripts/aggregate_agent_metrics.py | Implements strict parse-error detail capping with an explicit overflow sentinel entry. |
| templates/consumer-repo/scripts/aggregate_agent_metrics.py | Mirrors the same parse-error capping changes for consumer template sync. |
| .github/workflows/agents-verify-to-new-pr.yml | Pins external actions by SHA and applies small readability tweaks inside github-script blocks. |
| templates/consumer-repo/.github/workflows/agents-verify-to-new-pr.yml | Mirrors the pinned-action and formatting changes for consumer template sync. |
20 tasks
Owner
Author
|
Closing as superseded by #1910. The source fixes from this PR were covered by the merged #1909/#1910 path, and this branch is now stale against main: merging it would drop later Health 68, GitNexus, and aggregate overflow hardening already present on ffb5480. The refreshed campaign run 24963833320 reports 0 actionable/claimable local Codex items for #1836. |
19 tasks
19 tasks
This was referenced Apr 26, 2026
18 tasks
18 tasks
This was referenced Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agents-verify-to-new-pr.ymlaction references back to the vetted commit SHAs in both the source workflow and consumer template.Validation
pytest tests/scripts/test_aggregate_agent_metrics.py -qpytest tests/workflows/test_workflow_agents_consolidation.py tests/workflows/test_github_api_retry_standard.py -qpython scripts/validate_workflow_yaml.py .github/workflows/agents-verify-to-new-pr.yml templates/consumer-repo/.github/workflows/agents-verify-to-new-pr.ymlpython scripts/validate_template_sync.pygit diff --checkRelated consumer sync review: stranske/Travel-Plan-Permission#931