Harden sync review and drift telemetry contracts - #1910
Conversation
GitHub Actions
Error
Automated Status SummaryHead SHA: e3dc515
Coverage Overview
Coverage Trend
Top Coverage Hotspots (lowest coverage)
Updated automatically; will refresh on subsequent CI/Docker completions. Keepalive checklistScopeSync/Dependabot Campaign QueueRemote GitHub Actions owns discovery for sync-generated and Dependabot PR rounds. Local Codex should only claim items from this issue when SummaryContext for AgentRelated Issues/PRs
Tasks
Acceptance criteria
|
GitHub Actions
Inactive
fd35780 to
e9d9dbf
Compare
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull request overview
This PR hardens consumer sync/review automation by tightening supply-chain integrity for a consumer-facing workflow, improving parse-error telemetry compaction while preserving total counts, and making drift-issue mutation more resilient when GitHub REST rate limits are exhausted.
Changes:
- Pin
agents-verify-to-new-prworkflow actions to commit SHAs (with version comments) in both source and consumer template copies. - Update parse-error detail aggregation to cap stored details deterministically while keeping accurate total counts (plus new/updated tests).
- Adjust Health 68 drift workflow to skip issue lookup/update/comment/create when rate-limited, while preserving the drift artifact as the durable output.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
tests/scripts/test_aggregate_agent_metrics.py |
Adds/updates tests to validate capped parse-error detail storage and retained total counts. |
scripts/aggregate_agent_metrics.py |
Refines _append_parse_error_detail to cap stored details and aggregate overflow into a stable marker entry. |
templates/consumer-repo/scripts/aggregate_agent_metrics.py |
Mirrors the same parse-error aggregation changes for consumer-synced script parity. |
.github/workflows/agents-verify-to-new-pr.yml |
Pins commonly used actions to SHA for workflow supply-chain hardening. |
templates/consumer-repo/.github/workflows/agents-verify-to-new-pr.yml |
Mirrors the SHA pinning for consumer template parity. |
.github/workflows/health-68-consumer-sync-drift.yml |
Adds rate-limit detection and early-exit behavior to avoid mutating drift issues when REST core is exhausted. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fd35780a58
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return | ||
|
|
||
| details.append(replace(detail, line=None)) | ||
| details[-1] = ParseErrorDetail( |
There was a problem hiding this comment.
When details is at capacity and a new reason is appended, this replacement can erase both the incoming detail and the displaced tail detail into a generic additional-parse-errors-after-detail-limit bucket. In _read_ndjson, that means legacy-json-fallback-buffer-limit can disappear if the tail entry is a one-off reason (for example a single non-object-json in a very large malformed file), even though the fallback buffer limit was actually hit. This breaks the parse-error contract for consumers that key on the fallback marker reason.
Useful? React with 👍 / 👎.
e9d9dbf to
d333fef
Compare
GitHub Actions
Inactive
Related to campaign issue #1836
Automated Status Summary
Scope
Sync/Dependabot Campaign Queue
Remote GitHub Actions owns discovery for sync-generated and Dependabot PR rounds. Local Codex should only claim items from this issue when
needs-local-codexwork is queued.Summary
Context for Agent
Related Issues/PRs
Tasks
Acceptance criteria
sync/workflows-a038a7cee71c(91b8235d3374)Head SHA: d333fef
Latest Runs: ✅ success — Gate
Required: gate: ✅ success