Skip to content

[codex] Normalize verifier telemetry contracts - #1923

Merged
stranske merged 1 commit into
mainfrom
codex/workflows-contract-hardening-105
Apr 26, 2026
Merged

[codex] Normalize verifier telemetry contracts#1923
stranske merged 1 commit into
mainfrom
codex/workflows-contract-hardening-105

Conversation

@stranske

@stranske stranske commented Apr 26, 2026

Copy link
Copy Markdown
Owner

Source: Issue #1836

Related to campaign issue #1836

Automated Status Summary

Scope

Sync/Dependabot Campaign Queue

Remote GitHub Actions owns discovery for sync-generated and Dependabot PR rounds. Local Codex should only claim items from this issue when needs-local-codex work is queued.

Summary

Context for Agent

Related Issues/PRs

Tasks

  • Updated: 2026-04-26T21:19:27.410Z
  • Repos checked: 11/11
  • Open sync PRs: 598
  • Open Dependabot PRs: 0
  • Active review threads queued: 1162
  • Items needing local Codex: 0
  • Actionable local Codex items: 0
  • Claimable local Codex items: 0
  • Source-fixed candidates: 0
  • Superseded sync candidates: 120
  • Finished local results without published source changes: 0
  • Claimed local Codex items: 0
  • Next claim lease expires: -

Acceptance criteria

  • Status: local-codex-superseded-sync-candidate
  • Source repo: stranske/Workflows
  • Source sync state: superseded (PR 8c201f72e3ed / current d663bb30e7f5)

Head SHA: 83b09b9
Latest Runs: ⏹️ cancelled — Gate
Required: gate: ⏹️ cancelled

Workflow / Job Result Logs
Agents Auto-Pilot ⏭️ skipped View run
Agents Bot Comment Handler ✅ success View run
Agents Keepalive Loop ⏹️ cancelled View run
Agents Verifier ✅ success View run
Auto-label Dependabot PRs ⏭️ skipped View run
CI Autofix Loop ⏹️ cancelled View run
Copilot code review ✅ success View run
Create Issue from Verification (Enhanced) ⏭️ skipped View run
Create New PR from Verification ⏭️ skipped View run
Gate ⏹️ cancelled View run
Health 40 Sweep ✅ success View run
Health 44 Gate Branch Protection ✅ success View run
Health 45 Agents Guard ⏹️ cancelled View run
Health 50 Security Scan ✅ success View run
Health 72 Template Sync ✅ success View run
Maint 52 Validate Workflows ✅ success View run
PR 11 - Minimal invariant CI ✅ success View run
Selftest CI ✅ success View run
Validate Sync Manifest ✅ success View run

Copilot AI review requested due to automatic review settings April 26, 2026 21:39
@agents-workflows-bot

agents-workflows-bot Bot commented Apr 26, 2026

Copy link
Copy Markdown
Contributor

Automated Status Summary

Head SHA: 90f51bb
Latest Runs: ⏳ pending — Gate
Required contexts: Gate / gate, Health 45 Agents Guard / guard
Required: core tests (3.12): ⏳ pending, core tests (3.13): ⏳ pending, docker smoke: ⏳ pending, gate: ⏳ pending

Workflow / Job Result Logs
(no jobs reported) ⏳ pending

Coverage Overview

  • Coverage history entries: 1

Coverage Trend

Metric Value
Current 93.12%
Baseline 85.00%
Delta +8.12%
Minimum 70.00%
Status ✅ Pass

Top Coverage Hotspots (lowest coverage)

File Coverage Missing
src/cli_parser.py 81.8% 4
src/percentile_calculator.py 95.0% 1
src/aggregator.py 95.0% 2
src/__init__.py 100.0% 0
src/ndjson_parser.py 100.0% 0

Updated automatically; will refresh on subsequent CI/Docker completions.


Keepalive checklist

Scope

No scope information available

Tasks

  • No tasks defined

Acceptance criteria

  • No acceptance criteria defined

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 83b09b90d6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

if (isPreContractVerifierModelRecord(record, metadata, modelMetadataContract)) {
legacyMissingModelRecords.push(missingRecord);
} else {
if (!verifierMode) missingUnknownModeRecordCount += 1;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Count explicit unknown modes in unknown-mode metric

The new unknown-mode counter only increments when verifier_mode is blank, so records that explicitly set verifier_mode to 'unknown' are added to missing_model_records but not included in missing_model_unknown_mode_record_count. That creates an inconsistent machine-readable contract (and markdown summary) for the exact category this field is meant to report, which can undercount unknown-mode gaps in post-contract enforcement windows.

Useful? React with 👍 / 👎.

@stranske
stranske merged commit 7ca76b5 into main Apr 26, 2026
106 of 115 checks passed
@stranske
stranske deleted the codex/workflows-contract-hardening-105 branch April 26, 2026 21:43
@stranske
stranske removed the request for review from Copilot April 26, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant