[codex] Normalize verifier telemetry contracts - #1923
Conversation
Automated Status SummaryHead SHA: 90f51bb
Coverage Overview
Coverage Trend
Top Coverage Hotspots (lowest coverage)
Updated automatically; will refresh on subsequent CI/Docker completions. Keepalive checklistScopeNo scope information available Tasks
Acceptance criteria
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 83b09b90d6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (isPreContractVerifierModelRecord(record, metadata, modelMetadataContract)) { | ||
| legacyMissingModelRecords.push(missingRecord); | ||
| } else { | ||
| if (!verifierMode) missingUnknownModeRecordCount += 1; |
There was a problem hiding this comment.
Count explicit unknown modes in unknown-mode metric
The new unknown-mode counter only increments when verifier_mode is blank, so records that explicitly set verifier_mode to 'unknown' are added to missing_model_records but not included in missing_model_unknown_mode_record_count. That creates an inconsistent machine-readable contract (and markdown summary) for the exact category this field is meant to report, which can undercount unknown-mode gaps in post-contract enforcement windows.
Useful? React with 👍 / 👎.
Related to campaign issue #1836
Automated Status Summary
Scope
Sync/Dependabot Campaign Queue
Remote GitHub Actions owns discovery for sync-generated and Dependabot PR rounds. Local Codex should only claim items from this issue when
needs-local-codexwork is queued.Summary
Context for Agent
Related Issues/PRs
Tasks
Acceptance criteria
Head SHA: 83b09b9
Latest Runs: ⏹️ cancelled — Gate
Required: gate: ⏹️ cancelled