Skip to content

chore: sync workflow templates - #619

Closed
stranske wants to merge 1 commit into
mainfrom
sync/workflows-a038a7cee71c
Closed

chore: sync workflow templates#619
stranske wants to merge 1 commit into
mainfrom
sync/workflows-a038a7cee71c

Conversation

@stranske

Copy link
Copy Markdown
Owner

Sync Summary

Files Updated

  • agents-verify-to-new-pr.yml: Verify to new PR - creates follow-up issue and immediately dispatches auto-pilot to prepare a replacement PR (bridge inlined)
  • aggregate_agent_metrics.py: Aggregates downloaded weekly agent metrics - required by agents-weekly-metrics.yml

Files Skipped

  • pr-00-gate.yml: File exists and sync_mode is create_only
  • ci.yml: File exists and sync_mode is create_only
  • dependabot.yml: File exists and sync_mode is create_only
  • llm_slots.json: None

Review Checklist

  • CI passes with updated workflows
  • No repo-specific customizations were overwritten

Source: stranske/Workflows
Source SHA: 2f8e368aab2513497f1f5b5bd504618e94efae53
Template hash: a038a7cee71c
Sync branch: sync/workflows-a038a7cee71c
Consumer repo: stranske/Template
Manifest: .github/sync-manifest.yml

Automated sync from stranske/Workflows
Template hash: a038a7cee71c

Changes synced from sync-manifest.yml
Copilot AI review requested due to automatic review settings April 26, 2026 18:12
@stranske stranske added sync Automated sync from Workflows automated Automated sync from Workflows labels Apr 26, 2026
@stranske-keepalive

Copy link
Copy Markdown
Contributor

⚠️ Action Required: Unable to determine source issue for PR #619. The PR title, branch name, or body must contain the issue number (e.g. #123, branch: issue-123, or the hidden marker ).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Syncs workflow templates from stranske/Workflows into this consumer repo, updating a verification workflow and the weekly metrics aggregation helper.

Changes:

  • Pin actions/github-script, actions/checkout, and actions/upload-artifact to full commit SHAs in agents-verify-to-new-pr.yml.
  • Adjust parse-error detail aggregation logic in scripts/aggregate_agent_metrics.py to better handle overflow beyond the stored-detail limit.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
scripts/aggregate_agent_metrics.py Updates parse-error detail consolidation behavior when the in-memory limit is reached.
.github/workflows/agents-verify-to-new-pr.yml Pins previously floating GitHub Actions references to full SHAs.

details[index] = replace(existing, line=None, count=existing.count + detail.count)
return

details[-1] = replace(detail, line=None, count=details[-1].count + detail.count)

Copilot AI Apr 26, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the detail limit is reached and no existing entry matches, the fallback details[-1] = replace(detail, ...) overwrites the last stored detail’s path/artifact/reason with the new one while also carrying over the previous last entry’s count. This mixes counts and can misattribute parse errors in the summary/counters. Consider aggregating overflow into the existing last entry (preserving its fields) or reserving a dedicated "overflow/other" bucket entry instead of replacing an arbitrary detail with a different one.

Suggested change
details[-1] = replace(detail, line=None, count=details[-1].count + detail.count)
details[-1] = replace(details[-1], line=None, count=details[-1].count + detail.count)

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated Automated sync from Workflows sync Automated sync from Workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants