Release: Prerelease 10.4.0-alpha.16#34695
Merged
Merged
Conversation
…dons` Adds a new `rn-ondevice-addons-to-device-addons` automigration that moves on-device addons (packages whose name contains `ondevice`) from the shared `addons` array into a new `deviceAddons` array in `.rnstorybook/main.ts`. This is needed because Storybook Core evaluates every entry in `addons` as a Node.js preset, which on-device addons are not, and that causes `storybook extract` to fail. Split out of #34333 (M8). Tracking issue: #34276. Made-with: Cursor
Adds a self-contained generator that creates the `.rnstorybook/index.{ts,js}`
entry point for React Native projects, copying it from a static template and
choosing the file extension based on the project's language preference
(TypeScript vs JavaScript).
The entry point template registers a root component via
`AppRegistry.registerComponent` and configures `getStorybookUI` with storage,
producing a user-editable file.
Files added:
- `src/generators/REACT_NATIVE/generateEntrypoint.ts` — the generator
- `src/generators/REACT_NATIVE/generateEntrypoint.test.ts` — full coverage
- `templates/react-native/index.js` — the static template
This module is intentionally not yet wired into the React Native generator;
that orchestration arrives in M3.
Split out of #34333 (M2). Tracking issue: #34276.
Made-with: Cursor
Updated the migration documentation for React Native to specify that on-device addons must now be listed under the `deviceAddons` key in `.rnstorybook/main.ts`. Enhanced the automigration logic to ensure it correctly identifies and renames the `addons` key to `deviceAddons`, while also improving test coverage for various scenarios related to the migration process.
Agent-Logs-Url: https://github.com/storybookjs/storybook/sessions/838b61dd-d549-417a-b74d-a0bb2f49961d Co-authored-by: ndelangen <3070389+ndelangen@users.noreply.github.com>
Co-authored-by: Copilot <copilot@github.com>
Agent-Logs-Url: https://github.com/storybookjs/storybook/sessions/1cf492bb-b5ad-414e-9e0f-5453da78c35d Co-authored-by: ndelangen <3070389+ndelangen@users.noreply.github.com>
This change modifies the mock implementation of `findConfigFile` in the `rn-ondevice-addons-to-device-addons` test to return `null` instead of `undefined`, ensuring more accurate test behavior.
This change updates the type casting for the `node` variable in the `rn-ondevice-addons-to-device-addons` migration logic, ensuring compatibility when setting the `deviceAddons` field in the main configuration.
…relaxed-limits
…tegration - Moved AsyncStorage import to the top of the `index.expo.js` file for better visibility. - Updated `index.js` to use `shouldPersistSelection` instead of `enableWebsockets` for storage configuration. - Added a user-editable comment in `index.expo.js` to clarify usage for developers.
Chore: Move eslint-plugin lib formatting to oxfmt
storybook-bot
force-pushed
the
version-non-patch-from-10.4.0-alpha.15
branch
from
0eccc25 to
5ce91e9
Compare
JReinhold
added
ci:daily
…pshots - Replaced direct value assertions with inline snapshots for better readability and maintainability. - Ensured that the tests accurately reflect the expected output for various entrypoint scenarios. - Improved test coverage for the generated output paths and content checks.
…ne snapshots - Updated assertions to use inline snapshots for improved clarity and maintainability. - Ensured the tests accurately reflect the expected output structure and content for various entrypoint scenarios. - Enhanced test coverage for the generated output, including imports and component registration.
…ration ReactNative: Add true entrypoint generation
Co-authored-by: Copilot <copilot@github.com>
…gents Agentic Setup: Show Discord and human docs only to humans
storybook-bot
force-pushed
the
version-non-patch-from-10.4.0-alpha.15
branch
from
5ce91e9 to
d347809
Compare
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 93 | 93 | 0 |
| Self size | 1.12 MB | 1.12 MB | 0 B |
| Dependency size | 23.78 MB | 24.67 MB | 🚨 +891 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-native-web-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 122 | 122 | 0 |
| Self size | 30 KB | 30 KB | 🎉 -18 B 🎉 |
| Dependency size | 24.85 MB | 25.74 MB | 🚨 +891 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/react-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 83 | 83 | 0 |
| Self size | 36 KB | 36 KB | 0 B |
| Dependency size | 21.56 MB | 22.45 MB | 🚨 +891 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/cli
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 184 | 184 | 0 |
| Self size | 836 KB | 879 KB | 🚨 +43 KB 🚨 |
| Dependency size | 68.27 MB | 68.28 MB | 🚨 +9 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request that bumps the version from
10.4.0-alpha.15to10.4.0-alpha.16.Once this pull request is merged, it will trigger a new release of version
10.4.0-alpha.16.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next, that will be part of this release:deviceAddons#34659If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
10.4.0-alpha.16
deviceAddons- #34659, thanks ndelangen!