Skip to content

Agentic Setup: Fix onboarding copy prompt CTA appearing without hover#34696

Merged
Sidnioulz merged 1 commit into
nextfrom
sidnioulz/agentic-setup-ux-quirks
May 4, 2026
Merged

Agentic Setup: Fix onboarding copy prompt CTA appearing without hover#34696
Sidnioulz merged 1 commit into
nextfrom
sidnioulz/agentic-setup-ux-quirks

Conversation

@Sidnioulz
Copy link
Copy Markdown
Contributor

@Sidnioulz Sidnioulz commented May 4, 2026

Fixed with canary

image

Summary by CodeRabbit

  • Refactor
    • Enhanced component flexibility by allowing additional properties to be passed and forwarded to underlying button elements, improving extensibility without affecting existing functionality.

@Sidnioulz Sidnioulz requested a review from yannbf May 4, 2026 08:08
Copilot AI review requested due to automatic review settings May 4, 2026 08:08
@Sidnioulz Sidnioulz added build Internal-facing build tooling & test updates ci:normal Run our default set of CI jobs (choose this for most PRs). labels May 4, 2026
@Sidnioulz Sidnioulz changed the title Fix onboarding copy prompt CTA appearing without hover Agentic Setup: Fix onboarding copy prompt CTA appearing without hover May 4, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the CopyButton wrapper used in the sidebar onboarding checklist so it can forward additional props to the underlying ActionList.Button, which is needed for correct hover/targeting behavior (e.g., data-target-id used by the hover UI).

Changes:

  • Add rest props (...props) to CopyButton and spread them onto ActionList.Button.
  • Reformat the CopyButton return to support prop forwarding.
Comments suppressed due to low confidence (1)

code/core/src/manager/components/sidebar/ChecklistWidget.tsx:185

  • CopyButton now forwards ...props to ActionList.Button, but the component’s props type still only declares label, copyContent, and onClick. As a result, JSX usages like data-target-id (and any other button props you intend to forward) will still be a TypeScript error. Update the CopyButton props type to extend the underlying ActionList.Button props (e.g., React.ComponentProps<typeof ActionList.Button>), omitting conflicting keys like children/onClick as needed so callers can pass through DOM/ARIA/data attributes safely.
  ...props
}: {
  label: string;
  copyContent: string;
  onClick: (e: SyntheticEvent) => void;

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 62e92c99-1099-4ee6-bd75-11132d4e6be7

📥 Commits

Reviewing files that changed from the base of the PR and between 1cf16c5 and 236994f.

📒 Files selected for processing (1)
  • code/core/src/manager/components/sidebar/ChecklistWidget.tsx

📝 Walkthrough

Walkthrough

The CopyButton component in ChecklistWidget.tsx was modified to accept and forward additional props to its underlying ActionList.Button element, enabling greater flexibility in prop composition without explicit prop declaration.

Changes

Props Forwarding Enhancement

Layer / File(s) Summary
Component Enhancement
code/core/src/manager/components/sidebar/ChecklistWidget.tsx
CopyButton component destructures ...props from parameters and forwards them to the rendered ActionList.Button alongside copyButtonProps, allowing callers to pass additional props through the component.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@Sidnioulz Sidnioulz merged commit 3a0a6a2 into next May 4, 2026
132 of 137 checks passed
@Sidnioulz Sidnioulz deleted the sidnioulz/agentic-setup-ux-quirks branch May 4, 2026 11:33
@github-actions github-actions Bot mentioned this pull request May 4, 2026
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:normal Run our default set of CI jobs (choose this for most PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants