Skip to content

Types: Fix coverage type#34700

Merged
JReinhold merged 1 commit into
nextfrom
jeppe/fix-coverage-type
May 4, 2026
Merged

Types: Fix coverage type#34700
JReinhold merged 1 commit into
nextfrom
jeppe/fix-coverage-type

Conversation

@JReinhold
Copy link
Copy Markdown
Contributor

@JReinhold JReinhold commented May 4, 2026

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Caution

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced Vitest coverage reporter compatibility to accept a broader range of coverage configuration options.

@JReinhold JReinhold self-assigned this May 4, 2026
@JReinhold JReinhold added build Internal-facing build tooling & test updates ci:normal Run our default set of CI jobs (choose this for most PRs). labels May 4, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Fails
🚫 The "#### Manual testing" section must be filled in. Please describe how to test the changes you've made, step by step, so that reviewers can confirm your PR works as intended.

Generated by 🚫 dangerJS against 6ee1726

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 849f6ca0-737f-474f-a6ea-cb8aa0977a22

📥 Commits

Reviewing files that changed from the base of the PR and between 3a0a6a2 and 6ee1726.

📒 Files selected for processing (1)
  • code/addons/vitest/src/node/vitest-manager.ts

📝 Walkthrough

Walkthrough

The PR modifies a type assertion in the Vitest manager, widening the coverage options type from ResolvedCoverageOptions<'v8'> to ResolvedCoverageOptions, allowing the reporter to accept a broader range of coverage configuration types.

Changes

Coverage Type Widening

Layer / File(s) Summary
Type Annotation
code/addons/vitest/src/node/vitest-manager.ts
storybookCoverageReporter's coverageOptions parameter type is widened from ResolvedCoverageOptions<'v8'> | undefined to ResolvedCoverageOptions | undefined.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@JReinhold JReinhold merged commit 1ca796a into next May 4, 2026
109 of 131 checks passed
@JReinhold JReinhold deleted the jeppe/fix-coverage-type branch May 4, 2026 12:20
@github-actions github-actions Bot mentioned this pull request May 4, 2026
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-scan:human build Internal-facing build tooling & test updates ci:normal Run our default set of CI jobs (choose this for most PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants