Release: Patch 9.0.15#31912
Closed
github-actions[bot] wants to merge 6 commits into
Closed
Conversation
React: Bump @joshwooding/vite-plugin-react-docgen-typescript to 0.6.1 (cherry picked from commit f988c88)
CLI: Do not fail incompatible package check in doctor if only core packages used (cherry picked from commit 33923f9)
Core: Various fixes (cherry picked from commit 70fa4cd)
…k-nextjs NextJs-Vite: Enable next/font loading when using next-vite (cherry picked from commit 6214187)
UI: Set color scheme to sync scrollbar color with user-selected theme (cherry picked from commit 6b69631)
github-actions
Bot
requested review from
jonniebigodes and
kylegach
as code owners
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
11 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
Comment on lines
+105
to
108
| const storybookLikeDeps = Object.keys(allDeps).filter((dep) => dep.includes('storybook')); | ||
| if (storybookLikeDeps.length === 0 && !context.skipErrors) { | ||
| throw new Error('No Storybook dependencies found in the package.json'); | ||
| } |
Contributor
There was a problem hiding this comment.
logic: Error condition checking length === 0 needs to account for core packages before throwing the error, since the following filter will remove them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request that bumps the version from
9.0.14to9.0.15.Once this pull request is merged, it will trigger a new release of version
9.0.15.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next, that will be part of this release:🍒 Manual cherry picking needed!
The following pull requests could not be cherry-picked automatically because it resulted in merge conflicts.
For each pull request below, you need to either manually cherry pick it, or discard it by replacing the "patch:yes" label with "patch:no" on the PR and re-generate this PR.
git cherry-pick -m1 -x c9bfd0d99df207d84af7fc59b82ab0d88870e988git cherry-pick -m1 -x 879e5b3fd162619c3d222e64998ad23fa8c8897dIf you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
9.0.15
Greptile Summary
Patch release updating Storybook from 9.0.14 to 9.0.15 with multiple bug fixes and stability improvements across the codebase.
code/lib/cli-storybook/src/doctor/getIncompatibleStorybookPackages.tscode/core/src/manager/components/layout/Layout.tsxvite-plugin-storybook-nextjsvite-plugin-react-docgen-typescriptto 0.6.1