Skip to content

Ember: Allow ember v5 as peer deps#25893

Merged
valentinpalkovic merged 11 commits into
storybookjs:nextfrom
gossi:allow-ember-v5
Jul 1, 2025
Merged

Ember: Allow ember v5 as peer deps#25893
valentinpalkovic merged 11 commits into
storybookjs:nextfrom
gossi:allow-ember-v5

Conversation

@gossi
Copy link
Copy Markdown
Contributor

@gossi gossi commented Feb 3, 2024

Closes #25385

Thanks to #23435 which allowed to use sb8 with ember again, the ember community can happily go into experimentation with storybook and they do. As ember's major is already v5, the existing peer dependency produce nasty installation errors. That little fix takes that off and allows sb cli to run as designed, wo/ this package manager whoopsie.

What I did

Expand the peer dep range.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

There is no matrix to testing for ember versions, so I must say no to these.

Manual testing

I tested it locally and thanks to #23435 (which enabled ember v5), this is working. I tested it with my OSS design system (currently change is only local as it is in experimentation ;-) so I cannot link the related code).

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@gossi gossi added maintenance User-facing maintenance tasks ember bug and removed maintenance User-facing maintenance tasks labels Feb 3, 2024
@gossi
Copy link
Copy Markdown
Contributor Author

gossi commented Feb 5, 2024

Last time I contributed was on v6 😂 Tooling has changed, I actually did the PR on github itself. It may be that it requires an update to the yarn.lock file.

I checked the contributing docs, I was hoping to run yarn install (which is not a thing) but I dunno what I would need to do then ?!?

@veelci
Copy link
Copy Markdown

veelci commented Mar 1, 2024

@shilman Is there any chance that Ember 5 support could make it in the 8.0.0 release?

@shilman shilman changed the title Allow ember v5 as peer deps Ember: Allow ember v5 as peer deps Mar 1, 2024
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Mar 6, 2024

View your CI Pipeline Execution ↗ for commit 9ee379a.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 23s View ↗

☁️ Nx Cloud last updated this comment at 2025-07-01 07:31:18 UTC

@gossi
Copy link
Copy Markdown
Contributor Author

gossi commented Mar 21, 2024

I tried working on this PR and keep it updated with upstream branches. From my side, I consider this good but CI seems not to be happy with it:

  • DangerJS complains about missing tokens?
  • circle CI ain't run for whatever reason?

@shilman can you take a look? And maybe also let me know, how I can trigger this myself in the future?

@JReinhold JReinhold added the ci:normal Run our default set of CI jobs (choose this for most PRs). label Apr 25, 2024
@JReinhold
Copy link
Copy Markdown
Contributor

@gossi would this fix #26643 too?

@gossi
Copy link
Copy Markdown
Contributor Author

gossi commented Apr 25, 2024

@JReinhold no, it's not. This little "bug" helps with installation, some package managers are configured to stop or report "breakage", when peerDeps aren't fulfilled.

@tysonstewart
Copy link
Copy Markdown

What can we do to help get this PR merged? We've attempted to fork the repo and apply the change (thank you @gossi!), but the complexity of this repo has made it extremely difficult to use our fork rather than the official version.

@er-lim
Copy link
Copy Markdown

er-lim commented Oct 22, 2024

We are also having the same problem when migrating our project using storybook to Ember 5. Thanks @gossi for the fix !

There are conflicts on the PR and, by reading comments, CI seems to not be triggered on the last commit.
What can we do to make this PR progress ?

@storybook-app-bot
Copy link
Copy Markdown

Package Benchmarks

Commit: 9ee379a, ran on 1 July 2025 at 07:18:16 UTC

The following packages have significant changes to their size or dependencies:

@storybook/ember

Before After Difference
Dependency count 204 202 🎉 -2 🎉
Self size 28 KB 28 KB 🚨 +2 B 🚨
Dependency size 28.75 MB 27.94 MB 🎉 -810 KB 🎉
Bundle Size Analyzer Link Link

@valentinpalkovic valentinpalkovic added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jul 1, 2025
@valentinpalkovic valentinpalkovic merged commit 879e5b3 into storybookjs:next Jul 1, 2025
52 of 57 checks passed
ghengeveld pushed a commit that referenced this pull request Jul 7, 2025
Ember: Allow ember v5 as peer deps
(cherry picked from commit 879e5b3)
ghengeveld pushed a commit that referenced this pull request Jul 8, 2025
Ember: Allow ember v5 as peer deps
(cherry picked from commit 879e5b3)
@github-actions github-actions Bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jul 8, 2025
@ndelangen ndelangen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug ci:normal Run our default set of CI jobs (choose this for most PRs). ember patch:done Patch/release PRs already cherry-picked to main/release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add Ember 5 support

8 participants