NextJs-Vite: Enable next/font loading when using next-vite#31906
Conversation
|
@valentinpalkovic |
There was a problem hiding this comment.
LGTM
2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
|
View your CI Pipeline Execution ↗ for commit 195b8ff.
☁️ Nx Cloud last updated this comment at |
Package BenchmarksCommit: No significant changes detected, all good. 👏 |
| "@storybook/react-vite": "workspace:*", | ||
| "styled-jsx": "5.1.6", | ||
| "vite-plugin-storybook-nextjs": "^2.0.3" | ||
| "vite-plugin-storybook-nextjs": "2.0.5" |
There was a problem hiding this comment.
| "vite-plugin-storybook-nextjs": "2.0.5" | |
| "vite-plugin-storybook-nextjs": "^2.0.5" |
There was a problem hiding this comment.
@valentinpalkovic
Thanks for reviewing!
Fixed by 195b8ff
|
Hi @jeremytenjo This change has not yet been incorporated in the current latest version. It appears that it will be incorporated in the next version 9.0.16, so it should be fixed if you wait a little longer. |
|
Awesome, Thank you! @k35o |
…k-nextjs NextJs-Vite: Enable next/font loading when using next-vite (cherry picked from commit 6214187)
storybookjs/vite-plugin-storybook-nextjs#44
storybookjs/vite-plugin-storybook-nextjs#43
What I did
In
vite-plugin-storybook-nextjs, there was an issue where the plugin would break when handling CSS generated bynext/fontdue to aJSON.parseerror.This bug has been fixed on the
vite-plugin-storybook-nextjsside, so this PR incorporates this change.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Updates
vite-plugin-storybook-nextjsdependency from ^2.0.3 to 2.0.5 to enable next/font support in the nextjs-vite framework, fixing a JSON.parse error when handling CSS generated by next/font.code/frameworks/nextjs-vite/package.jsonto pin dependency version to 2.0.5 for better stability