Vite: Fix storysource addon support#21096
Merged
Merged
Conversation
shilman
added a commit
that referenced
this pull request
Feb 17, 2023
shilman
added a commit
that referenced
this pull request
Feb 17, 2023
…source-loader Revert #21096 Vite: Fix storysource addon support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20421
Self-merging @tmeasday @joshwooding
What I did
This PR:
There's a bit of history behind this PR. Once upon a time,
addon-docsandaddon-storysourceboth depended on a library calledsource-loaderto load & display raw story source.addon-docsto a new library calledcsf-pluginhere: Addon-docs: Replace source-loader with csf-plugin #19680csf-pluginsupport for Vite and removedsource-loaderhere: Vite: Fix static source handling for addon-docs #20147csf-pluginand updatedaddon-docsin a way that brokeaddon-storysourceCsf-plugin: Move source to docs.source.originalSource #20665source-loader/storysourceto get things working in webpack, e.g. Source-loader: Fix export default variable references #20688addon-storysourceandaddon-docsare completely separated in both vite & webpack.The plan is to:
storysourcethat shares code withaddon-docsstorysource/source-loader, and sunset them in 8.0How to test
yarn task --task sandbox --start-from auto --template react-vite/default-ts --addon storysourceButtonstories and view theStorytab in the addons panelChecklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]