Skip to content

Source-loader: Fix export default variable references#20688

Merged
shilman merged 1 commit into
tom/sb-1147-update-api-of-source-blockfrom
shilman/20421-split-docs-storysource
Jan 20, 2023
Merged

Source-loader: Fix export default variable references#20688
shilman merged 1 commit into
tom/sb-1147-update-api-of-source-blockfrom
shilman/20421-split-docs-storysource

Conversation

@shilman

@shilman shilman commented Jan 19, 2023

Copy link
Copy Markdown
Member

Issue: #20421

What I did

Fixed source-loader to handle the pattern:

const meta = { ... };
export default meta;

// ...stories

I did this because we're now using this pattern in our CLI template stories & as the recommended pattern in 7.0. Even though we're not actively maintaining/developing source-loader, this is a very basic fix.

How to test

  • See attached unit test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

@tmeasday tmeasday left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman merged commit 882f864 into tom/sb-1147-update-api-of-source-block Jan 20, 2023
@shilman shilman deleted the shilman/20421-split-docs-storysource branch January 20, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants