Vite: Fix static source handling for addon-docs#20147
Merged
Merged
Conversation
joshwooding
force-pushed
the
add-csf-plugin-to-vite
branch
from
02d988c to
9d074e6
Compare
joshwooding
commented
Dec 8, 2022
| @@ -0,0 +1,15 @@ | |||
| import type { Plugin } from 'vite'; | |||
Contributor
Author
There was a problem hiding this comment.
Kept a plugin so vite-config stayed clean
IanVS
reviewed
Dec 8, 2022
| // @ts-expect-error - not sure what type to use here | ||
| addons.find((a) => [a, a.name].includes('@storybook/addon-docs'))?.options ?? {}; | ||
|
|
||
| return vite(docsOptions?.csfPluginOptions); |
Member
There was a problem hiding this comment.
It feels to me like @storybook/csf-plugin itself should take care of this...
Member
There was a problem hiding this comment.
I don't think csf-plugin should know about the user's main.js and it makes sense for addon-docs to glue things together like this. Hopefully this all goes away in 7.x with the annotations server & simplifies things even further.
shilman
changed the title
shilman
changed the title
shilman
approved these changes
Dec 8, 2022
| // @ts-expect-error - not sure what type to use here | ||
| addons.find((a) => [a, a.name].includes('@storybook/addon-docs'))?.options ?? {}; | ||
|
|
||
| return vite(docsOptions?.csfPluginOptions); |
Member
There was a problem hiding this comment.
I don't think csf-plugin should know about the user's main.js and it makes sense for addon-docs to glue things together like this. Hopefully this all goes away in 7.x with the annotations server & simplifies things even further.
This was referenced Dec 8, 2022
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #19882 #19554
What I did
How to test
If your answer is yes to any of these, please make sure to include it in your PR.