Conversation
🦋 Changeset detectedLatest commit: 2f6c893 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
… backwards compat Co-authored-by: JReinhold <5678122+JReinhold@users.noreply.github.com>
experimentalComponentsManifest → componentsManifest with backwards compat
…tted Co-authored-by: JReinhold <5678122+JReinhold@users.noreply.github.com>
Done in a250488. The README now clearly states that Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
commit: |
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
There was a problem hiding this comment.
Pull request overview
This PR updates the Storybook feature flag naming used across @storybook/addon-mcp and @storybook/mcp to reflect the core rename from experimentalComponentsManifest to componentsManifest, while keeping runtime compatibility for older Storybook versions in the addon.
Changes:
- Updated addon-side feature-flag detection to prefer
componentsManifestand fall back toexperimentalComponentsManifest. - Updated docs/tests/config templates to reference
componentsManifestand removed now-unnecessary explicit enabling in example configs. - Updated
@storybook/mcp’s 404 error hint and corresponding tests to use the new flag name.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/mcp/src/utils/get-manifest.ts | Updates 404 “enable manifest” hint to reference features.componentsManifest. |
| packages/mcp/src/utils/get-manifest.test.ts | Updates assertions and test naming for the new hint string. |
| packages/addon-mcp/src/utils/is-manifest-available.ts | Makes addon feature-flag detection prefer componentsManifest with legacy fallback. |
| packages/addon-mcp/src/utils/is-manifest-available.test.ts | Adds coverage for legacy flag name and updates feature mocks. |
| packages/addon-mcp/src/preset.test.ts | Updates mocked features flag name in preset-related tests. |
| packages/addon-mcp/src/mcp-handler.test.ts | Updates mocked features flag name in handler tests. |
| packages/addon-mcp/README.md | Updates docs to new flag name and removes “Experimental” labeling. |
| eval/templates/grading/.storybook/main.ts | Removes explicit feature flag config now that it defaults to enabled. |
| apps/internal-storybook/.storybook/main.ts | Removes explicit feature flag config now that it defaults to enabled. |
| .github/instructions/addon-mcp.instructions.md | Removes docs toolset “requires experimental flag” note. |
| .github/copilot-instructions.md | Updates internal guidance to reflect renamed flag + legacy fallback. |
| .changeset/components-manifest-flag-rename.md | Adds changeset entry documenting the feature-flag rename. |
Bundle ReportChanges will increase total bundle size by 77 bytes (0.16%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: @storybook/mcp-esmAssets Changed:
Files in
|
… 404 hint Co-authored-by: JReinhold <5678122+JReinhold@users.noreply.github.com>
Needs storybookjs/storybook#33974 to be released first.
experimentalComponentsManifestpackages/addon-mcp/src/tools/is-manifest-available.ts— backwards-compat feature flag checkpackages/addon-mcp/src/tools/is-manifest-available.test.ts— use new flag name in mock, add backwards-compat test casespackages/mcp/src/utils/get-manifest.ts— 404 hint mentions bothcomponentsManifestandexperimentalComponentsManifestfor older Storybook versionspackages/mcp/src/utils/get-manifest.test.ts— asserts hint contains both flag namespackages/addon-mcp/README.md— reflect thatcomponentsManifestdefaults to true; "To enable" section shows both flag names with comments indicating which Storybook version each applies topackages/addon-mcp/src/preset.test.ts— test referencespackages/addon-mcp/src/mcp-handler.test.ts— test referencesapps/internal-storybook/.storybook/main.ts— remove explicitcomponentsManifest: true(defaults to true)eval/templates/grading/.storybook/main.ts— remove explicitcomponentsManifest: true(defaults to true).github/instructions/addon-mcp.instructions.md— remove "Requires feature flag" line (it's the default now).changeset/components-manifest-flag-rename.md— simplified to single sentence per reviewOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.