Manifest: Rename `experimentalComponentsManifest` → `componentsManifest`, default to `true` by Copilot · Pull Request #33974 · storybookjs/storybook

Copilot · 2026-03-02T15:03:45Z

Closes #

What I did

Graduates experimentalComponentsManifest out of experimental status. The flag is renamed to componentsManifest and now defaults to true — no backwards compatibility for the old name.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

stories
unit tests
integration tests
end-to-end tests

Manual testing

Create a react-vite sandbox
Build it
See that it has /manifests/components.json in its output
Disable manifests in main.ts: { features: { componentsManifest: false }
Build it again
See that it does not have the manifest files anymore.

Caution

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

Add or update documentation reflecting your changes
If you are deprecating/removing a feature, make sure to update
MIGRATION.MD

Checklist for Maintainers

When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
- bug: Internal changes that fixes incorrect behavior.
- maintenance: User-facing maintenance tasks.
- dependencies: Upgrading (sometimes downgrading) dependencies.
- build: Internal-facing build tooling & test updates. Will not show up in release changelog.
- cleanup: Minor cleanup style change. Will not show up in release changelog.
- documentation: Documentation only changes. Will not show up in release changelog.
- feature request: Introducing a new feature.
- BREAKING CHANGE: Changes that break compatibility in some way with current major version.
- other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Original prompt

Task

Rename the feature flag experimentalComponentsManifest to componentsManifest and make it default to true.

This is a clean break — no backwards compatibility for the old name.

Key principle: Since the default is now true, remove all places where experimentalComponentsManifest: true is set, rather than renaming them. Only keep/rename if the value is false (opt-out).

Files to change

1. code/core/src/types/modules/core-common.ts — Type definition

Find experimentalComponentsManifest?: boolean in the StorybookConfigRaw['features'] type

Rename it to componentsManifest?: boolean

2. code/core/src/core-server/dev-server.ts — Runtime check
Change features?.experimentalComponentsManifest → features?.componentsManifest
Since the feature now defaults to true, change the conditional from:
if (features?.experimentalComponentsManifest) {
to:
if (features?.componentsManifest !== false) {
3. code/.storybook/main.ts — Internal Storybook config

Remove experimentalComponentsManifest: true from the features object entirely (it's now the default — don't rename, just delete)

4. code/lib/cli-storybook/src/sandbox-templates.ts — Sandbox templates

Remove any experimentalComponentsManifest: true settings entirely (rely on default). Do NOT rename — just delete them.

5. Full repo search

Grep the entire codebase for experimentalComponentsManifest and update ALL remaining occurrences:

If set to true → remove the line entirely

If set to false → rename to componentsManifest: false

If referenced in logic/conditions → rename to componentsManifest

If referenced in comments/docs → rename to componentsManifest

Validation

After making changes:

Run cd code && yarn tsc --noEmit to ensure no TypeScript errors

Run cd code && yarn test in core to ensure no test failures

Run grep -r "experimentalComponentsManifest" code/ to confirm zero remaining references

Summary by CodeRabbit

Configuration Changes
- Renamed config option from experimentalComponentsManifest to componentsManifest.
- Component manifest generation is enabled by default and templates/configs updated to match.
Improvements
- Component manifest feature graduated from experimental to stable; manifest generation and registration now follow the new setting.

…to true Co-authored-by: JReinhold <5678122+JReinhold@users.noreply.github.com>

coderabbitai · 2026-03-02T15:23:19Z

📝 Walkthrough

Walkthrough

Renamed Storybook config flag experimentalComponentsManifest → componentsManifest, updated the type, removed the old flag from templates, and switched runtime checks to gate manifest write/registration on features.componentsManifest instead of the experimental flag.

Changes

Cohort / File(s)	Summary
Storybook config template `code/.storybook/main.ts`	Removed `experimentalComponentsManifest` feature flag from the sample main config.
Type definitions `code/core/src/types/modules/core-common.ts`	Renamed `StorybookConfigRaw.experimentalComponentsManifest?: boolean` → `StorybookConfigRaw.componentsManifest?: boolean` and added JSDoc with default.
Core server runtime `code/core/src/core-server/build-static.ts`, `code/core/src/core-server/dev-server.ts`, `code/core/src/core-server/presets/common-preset.ts`	Switched gating from `features.experimentalComponentsManifest` to `features.componentsManifest` (preset now enables `componentsManifest: true`), causing manifest write/register to run based on `componentsManifest`.
CLI sandbox template `code/lib/cli-storybook/src/sandbox-templates.ts`	Removed `experimentalComponentsManifest: true` from sandbox template feature set.

Sequence Diagram(s)

sequenceDiagram
    participant DevServer as DevServer
    participant Build as BuildStatic
    participant Manifests as ManifestWriter
    participant Telemetry as Telemetry

    DevServer->>DevServer: start
    alt features.componentsManifest !== false
        DevServer->>Manifests: registerManifests()
        Manifests-->>DevServer: registration complete
    end
    DevServer->>Telemetry: doTelemetry()

    Build->>Build: run static build
    alt features.componentsManifest !== false
        Build->>Manifests: writeManifests()
        Manifests-->>Build: manifests written
    end

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

React: Add components.json for dev and build with examples snippets #32682 — Renames/broadens the components manifest feature flag and updates build/dev gating.
React: Create a components manifest html page #32882 — Modifies components-manifest generation and touches dev-server/build-static behavior.
React: Add manifests/components.html page #32905 — Changes components manifest flow and core-server manifest endpoints.

✨ Finishing Touches

📝 Generate docstrings (stacked PR)
📝 Generate docstrings (commit on current branch)

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

🧹 Nitpick comments (1)

code/core/src/types/modules/core-common.ts (1)
504-504: Consider adding JSDoc documentation for the componentsManifest feature flag.

Other feature flags in this interface include JSDoc comments describing their purpose and default values (e.g., viewport, highlight, experimentalCodeExamples). Since this flag is graduating from experimental status, adding documentation would improve discoverability and help users understand when/why to opt out.
+    /**
+     * Enable generation of the components manifest file containing component metadata.
+     *
+     * `@default` true
+     */
     componentsManifest?: boolean;
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@code/core/src/types/modules/core-common.ts` at line 504, Add a JSDoc comment
for the componentsManifest feature flag above the componentsManifest?: boolean;
declaration in the core-common.ts interface: briefly describe what
enabling/disabling the components manifest does, note that it has graduated from
experimental, and document the default behavior/value and any
compatibility/opt-out implications so users can discover and understand when to
enable or disable it.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@code/core/src/types/modules/core-common.ts`:
- Line 504: Add a JSDoc comment for the componentsManifest feature flag above
the componentsManifest?: boolean; declaration in the core-common.ts interface:
briefly describe what enabling/disabling the components manifest does, note that
it has graduated from experimental, and document the default behavior/value and
any compatibility/opt-out implications so users can discover and understand when
to enable or disable it.

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 52873a9 and 6ac4b22.

📒 Files selected for processing (5)

code/.storybook/main.ts
code/core/src/core-server/build-static.ts
code/core/src/core-server/dev-server.ts
code/core/src/types/modules/core-common.ts
code/lib/cli-storybook/src/sandbox-templates.ts

💤 Files with no reviewable changes (2)

code/lib/cli-storybook/src/sandbox-templates.ts
code/.storybook/main.ts

nx-cloud · 2026-03-02T16:01:56Z

View your CI Pipeline Execution ↗ for commit 75082e9

Command	Status	Duration	Result
`nx run-many -t compile -c production --parallel=1`	✅ Succeeded	5m 57s	View ↗

☁️ Nx Cloud last updated this comment at 2026-03-11 12:46:53 UTC

kasperpeulen

@JReinhold The PR description is not following the PR template

code/core/src/types/modules/core-common.ts

kylegach · 2026-03-06T00:09:31Z

FYI, I documented this as part of the "AI" docs PR, here:

https://github.com/storybookjs/storybook/pull/33992/changes#diff-39a7878910719c8b2255699a090c2b8c297ae7c8a18d7896bd07fd05fc7a1e69

You can see a preview: https://deploy-preview-381--storybook-frontpage.netlify.app/docs/10.3/api/main-config/main-config-features

Initial plan

218a436

Copilot AI assigned Copilot and JReinhold Mar 2, 2026

Copilot started work on behalf of JReinhold March 2, 2026 15:03 View session

Rename experimentalComponentsManifest to componentsManifest, default …

6ac4b22

…to true Co-authored-by: JReinhold <5678122+JReinhold@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Rename feature flag experimentalComponentsManifest to componentsManifest~~ Rename experimentalComponentsManifest → componentsManifest, default to true Mar 2, 2026

Copilot stopped work on behalf of JReinhold due to an error March 2, 2026 15:07
The "Compile" custom setup step from your .github/workflows/copilot-setup-steps.yml file failed.

JReinhold self-requested a review March 2, 2026 15:20

JReinhold approved these changes Mar 2, 2026

View reviewed changes

JReinhold marked this pull request as ready for review March 2, 2026 15:21

coderabbitai bot reviewed Mar 2, 2026

View reviewed changes

JReinhold changed the title ~~Rename experimentalComponentsManifest → componentsManifest, default to true~~ Manifest: Rename experimentalComponentsManifest → componentsManifest, default to true Mar 2, 2026

JReinhold added maintenance User-facing maintenance tasks ci:normal manifest Component manifest generation labels Mar 2, 2026

Merge branch 'next' into copilot/rename-experimental-components-flag

b140798

JReinhold requested a review from kasperpeulen March 2, 2026 16:01

kasperpeulen reviewed Mar 3, 2026

View reviewed changes

code/core/src/types/modules/core-common.ts Show resolved Hide resolved

kasperpeulen requested changes Mar 3, 2026

View reviewed changes

JReinhold added 2 commits March 5, 2026 11:17

Apply suggestion from @JReinhold

42fbd9c

Merge branch 'next' into copilot/rename-experimental-components-flag

e518b4a

JReinhold requested a review from kasperpeulen March 5, 2026 10:17

JReinhold mentioned this pull request Mar 5, 2026

Rename experimentalComponentsManifest → componentsManifest with backwards compat storybookjs/mcp#181

Merged

13 tasks

Merge branch 'next' into copilot/rename-experimental-components-flag

fdebcb6

kylegach mentioned this pull request Mar 5, 2026

Docs: Add AI section #33992

Merged

4 tasks

Merge branch 'next' into copilot/rename-experimental-components-flag

0d4beef

elastic-renovate-prod bot mentioned this pull request Apr 1, 2026

chore(deps): update storybook monorepo to ^10.3.3 elastic/esql-js#76

Merged

1 task

cultureamp-renovate bot mentioned this pull request Apr 4, 2026

chore(deps): update storybook monorepo to v10 (major) cultureamp/kaizen-design-system#6563

Closed

1 task

This was referenced Apr 5, 2026

chore(deps): update storybook to v10.3.4 Endava/BEEQ#1631

Merged

chore(deps): update storybook monorepo to v10 (major) chakra-ui/chakra-ui#10759

Merged

chore(deps): update storybook to ^10.3.4 AriPerkkio/aria-live-capture#388

Merged

renovate-bot mentioned this pull request Apr 6, 2026

Update storybook monorepo to v10.3.4 JohnStrunk/66-laps#868

Merged

1 task

renolh bot mentioned this pull request Apr 8, 2026

chore(deps): update storybook monorepo (major) limehawk/React95#28

Closed

1 task

renolh bot mentioned this pull request Apr 11, 2026

chore(deps): update storybook monorepo (major) limehawk/React95#52

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Manifest: Rename `experimentalComponentsManifest` → `componentsManifest`, default to `true`#33974

Manifest: Rename `experimentalComponentsManifest` → `componentsManifest`, default to `true`#33974
JReinhold merged 8 commits intonextfrom
copilot/rename-experimental-components-flag

Copilot AI commented Mar 2, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Mar 2, 2026 •

edited

Loading

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Uh oh!

coderabbitai bot left a comment

Uh oh!

nx-cloud bot commented Mar 2, 2026 •

edited

Loading

Uh oh!

kasperpeulen left a comment •

edited

Loading

Uh oh!

Uh oh!

kylegach commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

Copilot AI commented Mar 2, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

Manual testing

Documentation

Checklist for Maintainers

🦋 Canary release

Task

Files to change

1. code/core/src/types/modules/core-common.ts — Type definition

2. code/core/src/core-server/dev-server.ts — Runtime check

3. code/.storybook/main.ts — Internal Storybook config

4. code/lib/cli-storybook/src/sandbox-templates.ts — Sandbox templates

5. Full repo search

Validation

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

nx-cloud bot commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kasperpeulen left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kylegach commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Copilot AI commented Mar 2, 2026 •

edited by coderabbitai bot

Loading

1. `code/core/src/types/modules/core-common.ts` — Type definition

2. `code/core/src/core-server/dev-server.ts` — Runtime check

3. `code/.storybook/main.ts` — Internal Storybook config

4. `code/lib/cli-storybook/src/sandbox-templates.ts` — Sandbox templates

coderabbitai bot commented Mar 2, 2026 •

edited

Loading

nx-cloud bot commented Mar 2, 2026 •

edited

Loading

kasperpeulen left a comment •

edited

Loading