Bump to Submariner 0.22.0-m0#2296
Conversation
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: skitt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
|
|
|
||
| // The following dependency has an API incompatibility with k8s.io/apiserver v0.33.x | ||
| // so downgrade to the previous minor version. | ||
| replace go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc => go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.60.0 |
There was a problem hiding this comment.
@skitt The API incompatibility is
k8s.io/apiserver/pkg/storage/storagebackend/factory/etcd3.go:328:39: undefined: otelgrpc.UnaryClientInterceptor
UnaryClientInterceptor was removed by open-telemetry/opentelemetry-go-contrib#7115.
The otelgrpc dependency is introduced by cloud-prepare -> google.golang.org/api -> go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc. It was google.golang.org/api@v0.236.0 that bumped otelgrpc to v0.61.0 so we could downgrade it and pin to v0.236.0. Not sure what the best thing to do is but it seems pinning otelgrpc to v0.60.0 is the most sensible option.
BTW, k8s.io/apiserver 1.34.0 alpha only bumps otelgrpc to v0.60.0.
There was a problem hiding this comment.
I agree pinning otelgrpc is the most sensible solution, I didn’t lgtm along with my approve because I’d rather have an additional pair of eyes on this.
There was a problem hiding this comment.
Seems best to pin otelgrpc to me as well. Thanks for the detailed write-up Tom.
|
/cc @vthapar @dfarrell07 |
|
/lgtm |
3 participants
No description provided.