Skip to content

Bump to Kubernetes 1.33 and Go 1.24#2168

Closed
vthapar wants to merge 1 commit intostolostron:mainfrom
vthapar:k8s-1.33
Closed

Bump to Kubernetes 1.33 and Go 1.24#2168
vthapar wants to merge 1 commit intostolostron:mainfrom
vthapar:k8s-1.33

Conversation

@vthapar
Copy link
Copy Markdown
Collaborator

@vthapar vthapar commented Jun 13, 2025

Depends on openshift/library-go#1952

Signed-off-by: Vishal Thapar <5137689+vthapar@users.noreply.github.com>
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign skeeey for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarqubecloud
Copy link
Copy Markdown

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 13, 2025

@vthapar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/build b81041b link true /test build
ci/prow/verify b81041b link true /test verify
ci/prow/golangci-lint b81041b link true /test golangci-lint
ci/prow/images b81041b link true /test images
ci/prow/unit b81041b link true /test unit
ci/prow/integration b81041b link true /test integration

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@skitt
Copy link
Copy Markdown
Member

skitt commented Jun 16, 2025

This shouldn’t be necessary, we’ll get it as a side-effect of the library-go bump when that’s ready, or the Submariner bump following the K8s 1.33 merge there. (It’s best to bump K8s along with Submariner to ensure that all the dependencies are aligned with K8s deprecations and removals.)

@vthapar
Copy link
Copy Markdown
Collaborator Author

vthapar commented Jun 17, 2025

This shouldn’t be necessary, we’ll get it as a side-effect of the library-go bump when that’s ready, or the Submariner bump following the K8s 1.33 merge there. (It’s best to bump K8s along with Submariner to ensure that all the dependencies are aligned with K8s deprecations and removals.)

Will dependabot be enough or will we need some changes in our code to make the bump work?

@skitt
Copy link
Copy Markdown
Member

skitt commented Jun 17, 2025

This shouldn’t be necessary, we’ll get it as a side-effect of the library-go bump when that’s ready, or the Submariner bump following the K8s 1.33 merge there. (It’s best to bump K8s along with Submariner to ensure that all the dependencies are aligned with K8s deprecations and removals.)

Will dependabot be enough or will we need some changes in our code to make the bump work?

Well, you had to change the Dockerfiles in this PR 😉. See #2206 for the whole set of changes — you could have a Go 1.24 PR separately, then dependabot would push a Submariner PR but that wouldn’t deal with the library-go bump (since that’s digest-based).

@openshift-merge-robot
Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions
Copy link
Copy Markdown

This PR/issue depends on:

@tpantelis
Copy link
Copy Markdown
Collaborator

Superseded by #2296

@tpantelis tpantelis closed this Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants