Remove UnaryServerInterceptor#7115
Merged
dmathieu merged 7 commits intoopen-telemetry:mainfrom Apr 4, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7115 +/- ##
=======================================
- Coverage 75.8% 75.8% -0.1%
=======================================
Files 207 207
Lines 19478 19412 -66
=======================================
- Hits 14783 14726 -57
+ Misses 4259 4253 -6
+ Partials 436 433 -3
🚀 New features to boost your workflow:
|
MrAlias
approved these changes
Apr 3, 2025
dmathieu
reviewed
Apr 4, 2025
dmathieu
approved these changes
Apr 4, 2025
This was referenced May 23, 2025
|
I'm a consumer of OTEL and the migration path from |
Member
|
Check the examples from https://pkg.go.dev/go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc |
|
@pellared those examples aren't helpful. We have custom code around |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7106