Skip to content

Remove UnaryServerInterceptor#7115

Merged
dmathieu merged 7 commits intoopen-telemetry:mainfrom
nirdosh17:chore/remove-UnaryServerInterceptor
Apr 4, 2025
Merged

Remove UnaryServerInterceptor#7115
dmathieu merged 7 commits intoopen-telemetry:mainfrom
nirdosh17:chore/remove-UnaryServerInterceptor

Conversation

@nirdosh17
Copy link
Copy Markdown
Contributor

@nirdosh17 nirdosh17 commented Apr 2, 2025

Closes #7106

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Apr 2, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions Bot requested a review from dashpole April 2, 2025 16:05
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.8%. Comparing base (47721e8) to head (b169f53).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #7115     +/-   ##
=======================================
- Coverage   75.8%   75.8%   -0.1%     
=======================================
  Files        207     207             
  Lines      19478   19412     -66     
=======================================
- Hits       14783   14726     -57     
+ Misses      4259    4253      -6     
+ Partials     436     433      -3     
Files with missing lines Coverage Δ
...ion/google.golang.org/grpc/otelgrpc/interceptor.go 88.0% <100.0%> (-0.6%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nirdosh17 nirdosh17 marked this pull request as ready for review April 2, 2025 16:40
@nirdosh17 nirdosh17 requested a review from a team as a code owner April 2, 2025 16:40
@nirdosh17 nirdosh17 requested a review from MrAlias April 3, 2025 19:48
Comment thread CHANGELOG.md Outdated
@miparnisari
Copy link
Copy Markdown

I'm a consumer of OTEL and the migration path from UnaryServerInterceptor to NewServerHandler doesn't look trivial - the signatures are very different. A short migration guide would be super helpful!

@pellared
Copy link
Copy Markdown
Member

pellared commented Jun 4, 2025

@miparnisari
Copy link
Copy Markdown

@pellared those examples aren't helpful. We have custom code around grpc.UnaryServerInterceptor and the new OTEL library doesn't fit that 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the deprecated UnaryServerInterceptor function from otelgrpc

5 participants