Skip to content

Fix/lhci package exports#219

Merged
stephansama merged 2 commits into
mainfrom
fix/lhci-package-exports
Feb 17, 2026
Merged

Fix/lhci package exports#219
stephansama merged 2 commits into
mainfrom
fix/lhci-package-exports

Conversation

@stephansama
Copy link
Copy Markdown
Owner

Checklist

  • Latest changes from main have been merged
  • Conflicts have been resolved
  • The branch is pointing to main
  • Eslint hasn't reported any issues.
  • All unit tests pass

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
packages Building Building Preview, Comment Feb 17, 2026 2:30am

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 17, 2026

🦋 Changeset detected

Latest commit: 5655e43

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@stephansama/types-lhci Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@stephansama stephansama merged commit cd4774b into main Feb 17, 2026
6 of 7 checks passed
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @stephansama, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue with package exports for the @stephansama/types-lhci package. It refines the build configuration by removing an unnecessary export option and explicitly exposes the schema.json file, ensuring that consumers can properly access the package's schema. This change improves the package's usability and adherence to modern module resolution practices.

Highlights

  • Build Configuration Adjustment: The "exports: true" option was removed from the build configuration in core/types-lhci/build.ts, potentially streamlining the build process for package exports.
  • Schema Export: A new export mapping for "./schema.json" was added to core/types-lhci/package.json, making the schema file directly accessible to consumers of the package.
  • Changelog Entry: A new changeset file (early-results-cheat.md) was introduced, documenting a patch update for @stephansama/types-lhci related to updated package exports.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • .changeset/early-results-cheat.md
    • Added a new changeset entry for the package update.
  • core/types-lhci/build.ts
    • Removed the "exports: true" option from the build configuration.
  • core/types-lhci/package.json
    • Added a new export mapping for "./schema.json".
Activity
  • The pull request author provided a checklist indicating that latest changes from main have been merged, conflicts resolved, branch pointing to main, no Eslint issues, and all unit tests pass.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 17, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Summary by CodeRabbit

Release Notes

  • New Features
    • Schema file is now publicly exported from the package for direct access.

Walkthrough

Updates the @stephansama/types-lhci package by removing the exports: true option from the build configuration and adding a new schema.json export mapping to the package exports, with a corresponding changelog entry documenting these modifications.

Changes

Cohort / File(s) Summary
Build Configuration
core/types-lhci/build.ts
Removed the exports: true option from the tsdown build configuration call.
Package Exports
core/types-lhci/package.json
Added a new export mapping for ./schema.json that references the built output at ./dist/schema.json.
Changelog
.changeset/early-results-cheat.md
Created changelog entry documenting a patch release with updated package exports.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Poem

🐰 A schema hops free, now exportable and bright,
The build flags aligned, the exports just right,
With dist laid to rest, the package takes flight! 📦✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/lhci-package-exports

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses the package export configuration for "@stephansama/types-lhci". The changes involve removing the "exports: true" option from the "tsdown" build configuration in "build.ts" and explicitly defining the "./schema.json" export in "package.json". These modifications ensure precise control over package exports, making the "schema.json" file accessible to consumers. A minor suggestion has been provided to enhance the clarity of the "build.ts" change for future maintainability.

Comment thread core/types-lhci/build.ts
await build({
dts: true,
entry: ["./src/index.ts"],
exports: true,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Removing 'exports: true' can be a subtle change. It's good practice to add a comment explaining why this option was removed, especially if it was causing conflicts with the explicit 'exports' field in 'package.json' or leading to unintended export behaviors. This improves clarity for future maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant