Fix/lhci package exports#219
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 5655e43 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello @stephansama, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue with package exports for the @stephansama/types-lhci package. It refines the build configuration by removing an unnecessary export option and explicitly exposes the schema.json file, ensuring that consumers can properly access the package's schema. This change improves the package's usability and adherence to modern module resolution practices. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Caution Review failedThe pull request is closed. 📝 WalkthroughSummary by CodeRabbitRelease Notes
WalkthroughUpdates the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Code Review
This pull request correctly addresses the package export configuration for "@stephansama/types-lhci". The changes involve removing the "exports: true" option from the "tsdown" build configuration in "build.ts" and explicitly defining the "./schema.json" export in "package.json". These modifications ensure precise control over package exports, making the "schema.json" file accessible to consumers. A minor suggestion has been provided to enhance the clarity of the "build.ts" change for future maintainability.
| await build({ | ||
| dts: true, | ||
| entry: ["./src/index.ts"], | ||
| exports: true, |
There was a problem hiding this comment.
Removing 'exports: true' can be a subtle change. It's good practice to add a comment explaining why this option was removed, especially if it was causing conflicts with the explicit 'exports' field in 'package.json' or leading to unintended export behaviors. This improves clarity for future maintainers.
Checklist
mainhave been mergedmain