Skip to content

Fix/lhci package exports #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephansama merged 2 commits into from
Feb 17, 2026
Merged

Fix/lhci package exports #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
316601b
feat(core): remove exports flag and add schema.json mapping
stephansama Feb 17, 2026
5655e43
docs(lhci): updated package exports
stephansama Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/early-results-cheat.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@stephansama/types-lhci": patch
---

updated package exports
1 change: 0 additions & 1 deletion core/types-lhci/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ const outDir = path.resolve("./dist");
await build({
dts: true,
entry: ["./src/index.ts"],
exports: true,
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Removing 'exports: true' can be a subtle change. It's good practice to add a comment explaining why this option was removed, especially if it was causing conflicts with the explicit 'exports' field in 'package.json' or leading to unintended export behaviors. This improves clarity for future maintainers.

});

const schemas = await import("./dist/index.js");
Expand Down
1 change: 1 addition & 0 deletions core/types-lhci/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
"import": "./dist/index.js",
"require": "./dist/index.cjs"
},
"./schema.json": "./dist/schema.json",
"./package.json": "./package.json"
},
"main": "./dist/index.cjs",
Expand Down
Loading