feat: add Korean (한국어) localization - #1460
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 12, 2026, 4:52 AM ET / 08:52 UTC. Summary Reproducibility: not applicable. this is a new language feature rather than a reported bug. Its behavior has a high-confidence validation path through catalog parity, focused tests, and packaged-app screenshots. Review metrics: 3 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Merge the current focused localization implementation after the exact-head required checks pass, preserving the catalog-parity tests and explicit account-state test isolation. Do we have a high-confidence way to reproduce the issue? Not applicable; this is a new language feature rather than a reported bug. Its behavior has a high-confidence validation path through catalog parity, focused tests, and packaged-app screenshots. Is this the best way to solve the issue? Yes. Extending the existing AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 8e50e8858588. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
d657b09 to
1565136
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1565136c0f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Fresh-bundle Peekaboo proof after rebasing to current
@clawsweeper re-review
|
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
|
Exact-head update for
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
Add native Korean as a first-class language: - ko.lproj/Localizable.strings with all 1040 strings translated to native macOS-style Korean (placeholders/format specifiers preserved) - register `ko` in the AppLanguage enum + Settings language picker - add the localized "language_korean" name to every existing catalog - extend LocalizationLanguageCatalogTests parity list Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
0e99190 to
a4a2284
Compare
|
Rebased onto current The branch keeps main's canonical error-filtering assertions and adds deterministic account/cache setup so the test no longer depends on local Codex authentication. Fresh proof:
Fresh CI is running for this head. @clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|


Summary
Adds native Korean (
ko) as a first-class language, integrated into CodexBar's existing localization system.ko.lproj/Localizable.strings— all 1,040 strings translated into native, idiomatic macOS-style Korean (Apple-standard terminology: 설정, 새로 고침, 종료, 메뉴 막대, 할당량, 크레딧 구매…). Format specifiers (%@,%lld,%1$@…) and\(name)interpolation placeholders are preserved exactly; positional specifiers are used where Korean word order requires reordering.koin theAppLanguageenum + Settings → Language picker."language_korean"name to every existing catalog (e.g. en→"Korean", ja→"韓国語", zh-Hans→"韩语") so the picker renders correctly in all languages.LocalizationLanguageCatalogTestsparity list.No changes were needed to
Localization.swift(itsdefaultcase already maps"ko"→Locale("ko")) orPackage.swift(.process("Resources")auto-bundles the new catalog).Using it
Selectable as 한국어 in Settings → Language (requires app restart). In the default System mode it is now picked up automatically for users whose macOS language is Korean.
Verification
plutil+ checks): 1040/1040 keys matchen, 0 missing/extra, 0 placeholder/format-specifier mismatches.swift buildsucceeds.CODEX_HOME; the branch also removes an inherited account-dependent CI failure.make checkpasses.Runtime proof
Freshly packaged app with Korean selected:
🤖 Generated with Claude Code