Add native Korean localization support - #1244
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 11, 2026, 1:33 PM ET / 17:33 UTC. Summary Reproducibility: unclear. The review failed before ClawSweeper could establish a reproduction path. Review metrics: none identified. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Risk before merge
Maintainer options:
Next step before merge
Review detailsBest possible solution: Retry the Codex review after fixing the execution failure. Do we have a high-confidence way to reproduce the issue? Unclear. The review failed before ClawSweeper could establish a reproduction path. Is this the best way to solve the issue? Unclear. Retry the review first so ClawSweeper can evaluate the actual issue and fix direction. AGENTS.md: unclear because the file could not be read completely. Codex review notes: model internal, reasoning high; reviewed against 3c2d23d1739a. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 51aa5edf9e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "CodexBar could not save the current system account before switching." = "CodexBar는 전환하기 전에 현재 시스템 계정을 저장할 수 없습니다."; | ||
| "CodexBar could not update managed account storage." = "CodexBar가 관리 계정 저장소를 업데이트할 수 없습니다."; | ||
| "CodexBar found another managed account that already uses the current system account. Resolve the duplicate account before switching." = "CodexBar가 현재 시스템 계정을 이미 사용하고 있는 다른 관리 계정을 찾았습니다. 전환하기 전에 중복 계정을 해결하세요."; | ||
| "CodexBar will ask macOS Keychain for “%@” so it can decrypt browser cookies and authenticate your account. Click OK to continue." = "CodexBar는 브라우저 쿠키를 해독하고 계정을 인증할 수 있도록 macOS 키체인에 "%@"을 요청합니다. 계속하려면 확인을 클릭하세요."; |
There was a problem hiding this comment.
Escape the placeholder quotes in Korean strings
The Korean Localizable.strings file is syntactically invalid because the translated value contains unescaped "%@" quotes. I checked this file with plutil -lint, which reports a missing semicolon at this line; as a result, the Korean localization table cannot be parsed when the new ko language is selected, and macOS/Xcode string resource validation may reject the resource. Escape these quotes (or use curly quotes) so the .strings file remains valid.
Useful? React with 👍 / 👎.
Screenshots@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
40a356d to
6d619bb
Compare
6d619bb to
81149ac
Compare
0e59073 to
fd353e9
Compare
fd353e9 to
9509804
Compare
|
Rebased and repaired this branch on current Proof:
I am holding merge for native-language review. The catalog still has clear user-visible machine-translation defects, including |
Add missing language picker keys to ko and fr/nl/uk/vi bundles, and include language_korean in the localization catalog test. Co-authored-by: Cursor <cursoragent@cursor.com>
…talogs) After rebasing onto origin/main, the invariant test 'localized catalogs include every app language label' requires every lproj to contain every language_<X> key. Add language_japanese to ko.lproj and language_korean to ja.lproj. No-op for app behavior; only catalog parity for invariant.
9509804 to
068fdd6
Compare
|
Superseded by #1460, which carries a native-contributor Korean catalog, full catalog/format regressions, and live menu/settings proof. Thank you @Yuxin-Qiao for starting the Korean localization work and for the screenshots and follow-up repairs here. Closing this branch to keep one canonical implementation. |



Summary
Adds Korean (
ko) as a first-class app localization.Changes
koto the language picker.Sources/CodexBar/Resources/ko.lproj/Localizable.strings.language_koreanlabels in existing localization files so the new option is shown consistently in the language menu.Validation
en.lproj.%@,%d, positional specifiers).swift test->3197 testspassed.