feat: add Korean (한국어) localization - #1
Closed
soohanpark wants to merge 1 commit into
Closed
Conversation
Add native Korean as a first-class language: - ko.lproj/Localizable.strings with all 1040 strings translated to native macOS-style Korean (placeholders/format specifiers preserved) - register `ko` in the AppLanguage enum + Settings language picker - add the localized "language_korean" name to every existing catalog - extend LocalizationLanguageCatalogTests parity list Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Owner
Author
|
Superseded by upstream PR steipete#1460 (targeting the original repo). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds native Korean (
ko) as a first-class language, integrated into CodexBar's existing localization system.ko.lproj/Localizable.strings— all 1,040 strings translated into native, idiomatic macOS-style Korean (Apple-standard terminology: 설정, 새로 고침, 종료, 메뉴 막대, 할당량, 크레딧 구매…). Format specifiers (%@,%lld,%1$@…) and\(name)interpolation placeholders are preserved exactly; positional specifiers are used where Korean word order requires reordering.koin theAppLanguageenum + Settings → Language picker."language_korean"name to every existing catalog (e.g. en→"Korean", ja→"韓国語", zh-Hans→"韩语") so the picker renders correctly in all languages.LocalizationLanguageCatalogTestsparity list.No changes were needed to
Localization.swift(itsdefaultcase already maps"ko"→Locale("ko")) orPackage.swift(.process("Resources")auto-bundles the new catalog).Using it
Selectable as 한국어 in Settings → Language (requires app restart). In the default System mode it is now picked up automatically for users whose macOS language is Korean.
Verification
plutil+ checks): 1040/1040 keys matchen, 0 missing/extra, 0 placeholder/format-specifier mismatches.swift buildsucceeds.MenuCardModelTestsdate assertion that hard-codes an English date whilesubscriptionDateStringusesLocale.current— both reproduce onmainwith these changes stashed).🤖 Generated with Claude Code