fix(backup): return error if there is no backup path set#7146
Merged
jrainville merged 1 commit intorelease/10.31.xfrom Nov 26, 2025
Merged
fix(backup): return error if there is no backup path set#7146jrainville merged 1 commit intorelease/10.31.xfrom
jrainville merged 1 commit intorelease/10.31.xfrom
Conversation
Member
Jenkins BuildsClick to see older builds (6)
|
1 task
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## release/10.31.x #7146 +/- ##
==================================================
Coverage ? 59.77%
==================================================
Files ? 804
Lines ? 113896
Branches ? 0
==================================================
Hits ? 68081
Misses ? 38854
Partials ? 6961
Flags with carried forward coverage won't be shown. Click here to find out more.
|
osmaczko
approved these changes
Nov 26, 2025
igor-sirotin
approved these changes
Nov 26, 2025
jrainville
force-pushed
the
fix/dont-backup-if-no-path
branch
from
848344f to
931cfe3
Compare
Needed for status-im/status-app#19377 For Android, we are setting the default path to empty string so that the user can know that they need to modify it. Otherwise, the default path was the datadir and users cannot access it. What this meant is that once the auto-backup was happening, the status-go code worked, but then it failed because of the missing user permission. To fix it, we just throw an error on empty paths in status-go. That way the backup just doesn't happen until the user selects a path.
jrainville
force-pushed
the
fix/dont-backup-if-no-path
branch
from
931cfe3 to
b68ebd0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for status-im/status-app#19377
For Android, we are setting the default path to empty string so that the user can know that they need to modify it. Otherwise, the default path was the datadir and users cannot access it.
What this meant is that once the auto-backup was happening, the status-go code worked, but then it failed because of the missing user permission.
Also, less code 👍