Skip to content

fix(backup): return error if there is no backup path set #7146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrainville merged 1 commit into from
Nov 26, 2025
Merged

fix(backup): return error if there is no backup path set #7146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions node/get_status_node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,14 +259,11 @@ func (n *StatusNode) StartLocalBackup() error {
return "", err
}

var backupDir string
if backupPath != "" {
backupDir = backupPath
} else {
backupDir = filepath.Join(n.config.RootDataDir, "backups")
if backupPath == "" {
return "", errors.New("backup path is not set")
}

fullPath := filepath.Join(backupDir, fmt.Sprintf("%s_user_data.bkp", compressedPubKey[len(compressedPubKey)-6:]))
fullPath := filepath.Join(backupPath, fmt.Sprintf("%s_user_data.bkp", compressedPubKey[len(compressedPubKey)-6:]))

return fullPath, nil
}
Expand Down
7 changes: 7 additions & 0 deletions tests-functional/tests/test_local_backup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
import os
import re

import pytest

from clients.status_backend import StatusBackend
from resources.constants import Account, user_1
from resources.test_data import profile_showcase_utils
from utils import fake
from clients.api import ApiResponseError

test_one_to_one_chat_id = (
"0x043329fc08727f15c4ec9a17bf7d6a3dc44e9d0d8f782a55804f3660b28827194a365dc1765cf96b6fa5cd666b9ee5298e8ac82f51f7952c4110cbf321d4f63864"
Expand Down Expand Up @@ -194,6 +196,11 @@ def test_local_backup(self, tmp_path):
assert group_chat_recovered, "Group chat was not restored correctly"
assert one_on_one_chat_recovered, "One-to-one chat was not restored correctly"

# Test that it fails if no backupPath is set
backend_client.settings_service.save_setting("backup-path", "")
with pytest.raises(ApiResponseError, match=re.escape("backup path is not set")):
backend_client.api_request_json("PerformLocalBackup", "")

# Change the backup path (Docker restricts access to a lot of folders)
backend_client.settings_service.save_setting("backup-path", "/usr/status-user/backups")

Expand Down