fix(backup): set backup path to empty string by default on Android and update backup popup#19391
Merged
jrainville merged 1 commit intorelease/2.36.xfrom Nov 27, 2025
Merged
Conversation
jrainville
requested review from
a team,
alexjba,
caybro,
micieslak and
noeliaSD
as code owners
Member
Jenkins BuildsClick to see older builds (23)
|
caybro
reviewed
Nov 25, 2025
Member
caybro
left a comment
caybro
left a comment
There was a problem hiding this comment.
LGTM in general, just wondering what about iOS
| proc getLocalBackupChosenPath*(self: LocalAccountSensitiveSettings): string {.slot.} = | ||
| let setting = self.getLocalBackupChosenPathSetting() | ||
| if setting == "": | ||
| when defined(android): |
Member
Author
There was a problem hiding this comment.
Apparently iOS is fine according to Volo. I think users can access the sandbox in iOS
caybro
approved these changes
Nov 26, 2025
jrainville
force-pushed
the
fix/android-backup-new-account
branch
from
7d883f8 to
04682dd
Compare
…d update backup popup Fixes #19377 Sets the backup path to empty string on Android to let users know that they need to set it. Modifies the "Enable message backup" popup to enable backups in general on Android.
jrainville
force-pushed
the
fix/android-backup-new-account
branch
from
04682dd to
9abb82d
Compare
micieslak
reviewed
Nov 28, 2025
Member
micieslak
left a comment
micieslak
left a comment
There was a problem hiding this comment.
After merge review: Looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do
Fixes #19377
Sets the backup path to empty string on Android to let users know that they need to set it. Modifies the "Enable message backup" popup to enable backups in general on Android.
Affected areas
Architecture compliance
My PR is consistent with this document: QML Architecture Guidelines
Screencapture of the functionality
Video showing the "new" popup plus it working. The error shown when clicking the Backup Now button is normal because no path is selected.
andrdoid-new-user-2.webm
Impact on end user
Makes it clear that users need to set a backup path for it to work on Android. Also prevents the error toast showing when it is not set
How to test
Risk
Low