Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show only file name in checksum, setup rustfmt in composite #41

Merged
merged 4 commits into from
May 15, 2024

Conversation

BowTiedDevOps
Copy link
Collaborator

@BowTiedDevOps BowTiedDevOps commented May 14, 2024

Description

This PR addresses 2 small but nice-to-have changes:

  • The checksum file generated has the path release/<file_name>. This has changed so it only includes the file_name (i.e. <file_name>), so the file is ready to be copy-pasted.
  • Setting the rust toolchain and checkouting the code inside composite actions for easier code maintenance, addressed in [CI] move rustfmt steps into the actions repo stacks-core#4794.

Example run: https://github.com/BowTiedDevOps/stacks-core/actions/runs/9087322966 (failed due to shutdown signal)
Example run: https://github.com/BowTiedDevOps/stacks-core/actions/runs/9087482799

@BowTiedDevOps BowTiedDevOps added the enhancement New feature or request label May 14, 2024
@BowTiedDevOps BowTiedDevOps requested a review from wileyj May 14, 2024 23:04
@BowTiedDevOps BowTiedDevOps self-assigned this May 14, 2024
@BowTiedDevOps BowTiedDevOps changed the title Retain file name in checksum, setup rustfmt in composite Show only file name in checksum, setup rustfmt in composite May 14, 2024
Copy link
Collaborator

@wileyj wileyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@wileyj wileyj merged commit c822d00 into stacks-network:main May 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants