Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Spark history server #187

Closed
wants to merge 61 commits into from

Conversation

razvan
Copy link
Member

@razvan razvan commented Jan 3, 2023

@razvan razvan linked an issue Jan 3, 2023 that may be closed by this pull request
4 tasks
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review finished. I would like to try it out in the meantime

docs/modules/ROOT/pages/usage.adoc Outdated Show resolved Hide resolved
rust/crd/src/history.rs Outdated Show resolved Hide resolved
rust/crd/src/history.rs Show resolved Hide resolved
rust/crd/src/lib.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/history_controller.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/history_controller.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/history_controller.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/spark_k8s_controller.rs Outdated Show resolved Hide resolved
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
During review we noticed that we currently can't verify S3 connections using a SecretClass. Ideally this would be fixed in this PR, but I'm fine with releasing without it and working on the Issue #194 directly afterwards

bors bot pushed a commit to stackabletech/stackablectl that referenced this pull request Jan 19, 2023
## Description

I suggest reviewing commits separately

Currently with stackabletech/spark-k8s-operator#187 it produces.
We should probably adopt the exposed services

```
┌──────────────────────┬───────────────┬──────────────────────────────┬───────────────────────────────────────────┬──────┐
│ Product              ┆ Name          ┆ Namespace                    ┆ Endpoints                                 ┆ Info │
╞══════════════════════╪═══════════════╪══════════════════════════════╪═══════════════════════════════════════════╪══════╡
│ spark-history-server ┆ spark-history ┆ kuttl-test-credible-crayfish ┆ node-http         http://172.18.0.4:32525 ┆      │
│                      ┆               ┆                              ┆ node-cleaner-http http://172.18.0.4:32589 ┆      │
└──────────────────────┴───────────────┴──────────────────────────────┴───────────────────────────────────────────┴──────┘
```

## Review Checklist
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added (or not applicable)
- [ ] Documentation added (or not applicable)
- [ ] Changelog updated (or not applicable)
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

Once the review is done, comment `bors r+` (or `bors merge`) to merge. [Further information](https://bors.tech/documentation/getting-started/#reviewing-pull-requests)
@razvan
Copy link
Member Author

razvan commented Jan 20, 2023

bors merge

bors bot pushed a commit that referenced this pull request Jan 20, 2023
@bors
Copy link

bors bot commented Jan 20, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Spark history server [Merged by Bors] - Spark history server Jan 20, 2023
@bors bors bot closed this Jan 20, 2023
@bors bors bot deleted the 124-implement-adr-22-spark-history-server branch January 20, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement ADR 22 (Spark history server)
3 participants