-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Spark history server #187
Conversation
Co-authored-by: Sebastian Bernauer <[email protected]>
Co-authored-by: Sebastian Bernauer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review finished. I would like to try it out in the meantime
Co-authored-by: Sebastian Bernauer <[email protected]>
Co-authored-by: Sebastian Bernauer <[email protected]>
Co-authored-by: Sebastian Bernauer <[email protected]>
Co-authored-by: Sebastian Bernauer <[email protected]>
Co-authored-by: Sebastian Bernauer <[email protected]>
Co-authored-by: Sebastian Bernauer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
During review we noticed that we currently can't verify S3 connections using a SecretClass. Ideally this would be fixed in this PR, but I'm fine with releasing without it and working on the Issue #194 directly afterwards
## Description I suggest reviewing commits separately Currently with stackabletech/spark-k8s-operator#187 it produces. We should probably adopt the exposed services ``` ┌──────────────────────┬───────────────┬──────────────────────────────┬───────────────────────────────────────────┬──────┐ │ Product ┆ Name ┆ Namespace ┆ Endpoints ┆ Info │ ╞══════════════════════╪═══════════════╪══════════════════════════════╪═══════════════════════════════════════════╪══════╡ │ spark-history-server ┆ spark-history ┆ kuttl-test-credible-crayfish ┆ node-http http://172.18.0.4:32525 ┆ │ │ ┆ ┆ ┆ node-cleaner-http http://172.18.0.4:32589 ┆ │ └──────────────────────┴───────────────┴──────────────────────────────┴───────────────────────────────────────────┴──────┘ ``` ## Review Checklist - [ ] Code contains useful comments - [ ] (Integration-)Test cases added (or not applicable) - [ ] Documentation added (or not applicable) - [ ] Changelog updated (or not applicable) - [ ] Cargo.toml only contains references to git tags (not specific commits or branches) Once the review is done, comment `bors r+` (or `bors merge`) to merge. [Further information](https://bors.tech/documentation/getting-started/#reviewing-pull-requests)
bors merge |
Fixes #124 #162 Jenkins: [Azure:heavy_check_mark:](https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/spark-k8s-operator-it-custom/60/) Co-authored-by: Andrew Kenworthy <[email protected]>
Pull request successfully merged into main. Build succeeded: |
Fixes #124 #162
Jenkins: Azure:heavy_check_mark: