Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 reference inconsistency #162

Closed
sbernauer opened this issue Oct 12, 2022 · 1 comment
Closed

S3 reference inconsistency #162

sbernauer opened this issue Oct 12, 2022 · 1 comment
Labels
release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. size/M type/bug

Comments

@sbernauer
Copy link
Member

Affected version

nightly

Current and expected behavior

Currently we have the following CRD

    s3bucket:
      inline:
        bucketName: some-dummy-value
        connection:
          reference: spark

As we only need to tell s3a the endpoint, credentials etc. but not he bucket we should use a S3ConnectionDef as follows:

    s3conncetion:
      reference: spark

Second inconsistency is in

pub const ACCESS_KEY_ID: &str = "accessKeyId";
pub const SECRET_ACCESS_KEY: &str = "secretAccessKey";

All the operators (and the official concepts docs) use accessKey and secretKey in the credentials secret.
We need to adopt the spark-k8s operator to adhere to the common convention so that S3Connections can be reused across multiple products.

Possible solution

  • Use S3ConnectionDef rather then S3BucketDef
  • Use accessKey and secretKey rather than accessKeyId and secretAccessKey

Additional context

No response

Environment

No response

Would you like to work on fixing this bug?

No response

@razvan
Copy link
Member

razvan commented Jan 20, 2023

Implemented as part of #187

@razvan razvan closed this as completed Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. size/M type/bug
Projects
None yet
Development

No branches or pull requests

3 participants