Skip to content
This repository has been archived by the owner on Feb 16, 2024. It is now read-only.

[Merged by Bors] - Add support for listing Spark History Servers #210

Closed
wants to merge 2 commits into from

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Jan 19, 2023

Description

I suggest reviewing commits separately

Currently with stackabletech/spark-k8s-operator#187 it produces.
We should probably adopt the exposed services

┌──────────────────────┬───────────────┬──────────────────────────────┬───────────────────────────────────────────┬──────┐
│ Product              ┆ Name          ┆ Namespace                    ┆ Endpoints                                 ┆ Info │
╞══════════════════════╪═══════════════╪══════════════════════════════╪═══════════════════════════════════════════╪══════╡
│ spark-history-server ┆ spark-history ┆ kuttl-test-credible-crayfish ┆ node-http         http://172.18.0.4:32525 ┆      │
│                      ┆               ┆                              ┆ node-cleaner-http http://172.18.0.4:32589 ┆      │
└──────────────────────┴───────────────┴──────────────────────────────┴───────────────────────────────────────────┴──────┘

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sbernauer
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Jan 19, 2023
## Description

I suggest reviewing commits separately

Currently with stackabletech/spark-k8s-operator#187 it produces.
We should probably adopt the exposed services

```
┌──────────────────────┬───────────────┬──────────────────────────────┬───────────────────────────────────────────┬──────┐
│ Product              ┆ Name          ┆ Namespace                    ┆ Endpoints                                 ┆ Info │
╞══════════════════════╪═══════════════╪══════════════════════════════╪═══════════════════════════════════════════╪══════╡
│ spark-history-server ┆ spark-history ┆ kuttl-test-credible-crayfish ┆ node-http         http://172.18.0.4:32525 ┆      │
│                      ┆               ┆                              ┆ node-cleaner-http http://172.18.0.4:32589 ┆      │
└──────────────────────┴───────────────┴──────────────────────────────┴───────────────────────────────────────────┴──────┘
```

## Review Checklist
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added (or not applicable)
- [ ] Documentation added (or not applicable)
- [ ] Changelog updated (or not applicable)
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

Once the review is done, comment `bors r+` (or `bors merge`) to merge. [Further information](https://bors.tech/documentation/getting-started/#reviewing-pull-requests)
@bors
Copy link

bors bot commented Jan 19, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add support for listing Spark History Servers [Merged by Bors] - Add support for listing Spark History Servers Jan 19, 2023
@bors bors bot closed this Jan 19, 2023
@bors bors bot deleted the spark-history-server branch January 19, 2023 14:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants