Allow embedding of PDF, video, etc. using image links

[srid]

Resolves #350

FYI @mnaoumov #341 (comment) - this is how it should be done.

[srid]

Doing it this way means this syntax will also work for other formats, like video formats:

![](foo.mp4)

[mnaoumov]

@srid Maybe Emanote.Pandoc.Link.InlineImage name has to be changed then? Don't you think it is confusing now?

[mnaoumov]

@srid maybe InlineStaticFile would be better ?

[srid]

InlineRef, defined under Emanote.Pandoc, knows nothing about non-Pandoc specific types (like StaticFile). So I'd say it is fine as is. The type exists simply to distinguish between the two possible inline links allowed by Pandoc AST.

[srid]

I actually should refactor the whole pandoc related rendering code one day. It has gotten way too complex. Meanwhile, I decoupled the Heist utilities to https://github.com/srid/heist-extra

[mnaoumov]

@srid I understand that Pandoc mistakenly calls everything Image but I guess your should not keep using that leaking abstraction further in your library. What if you rename it to InlineResource and maybe write in the comment that Pandoc mistakenly calls Text.Pandoc.Definition.Image all resources including images, videos, pdfs etc? This will make your library's API clearer and leaked abstractions from Pandoc will be encapsulated within Emanote.Pandoc.Link module

[srid]

Pandoc mistakenly calls Text.Pandoc.Definition.Image all resources including images, videos, pdfs etc?

Pandoc is behaving correctly. Per commonmark spec, ![]() can only be used for images.

https://commonmark.org/help/tutorial/08-images.html

It just so happens that Obsidian and the like decide to overload this syntax for embedding non-image resources.

If we want to improve the API properly, perhaps we should start from Pandoc itself (as its AST is not that flexible currently); eg.: jgm/pandoc-types#98

[mnaoumov]

@srid ok, I take my words back about misbehaving Pandoc. I'm so used to the embedded videos, audios, pdfs, so I forgot that pure Markdown still doesn't allow it