Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for embedded pdf #341

Merged
merged 11 commits into from
Sep 17, 2022
Merged

Add support for embedded pdf #341

merged 11 commits into from
Sep 17, 2022

Conversation

mnaoumov
Copy link
Contributor

Add support for embedded PDFs in markdown links and wikilinks

Required in #24

@srid
Copy link
Owner

srid commented Aug 25, 2022

This is a good feature to add; thanks, will review soon.

srid
srid requested changes Aug 25, 2022
View reviewed changes
Copy link
Owner

@srid srid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mnaoumov Functionality-wise, it looks good to me. I've left a few comments to address the code. Do you think there is a way to let the user customize the height instead of hardcoding it?

default/templates/hooks/more-head.tpl Outdated Show resolved Hide resolved
src/Emanote/Pandoc/Renderer/Embed.hs Outdated Show resolved Hide resolved
src/Heist/Extra/Splices/Pandoc/Render.hs Outdated Show resolved Hide resolved
@srid srid added this to the 0.8 milestone Aug 30, 2022
@srid srid merged commit 61fd13f into srid:master Sep 17, 2022
@mnaoumov
Copy link
Contributor Author

@srid why did you revert the change for markdown link pdf?

Then ![](book.pdf) won't render properly

@srid srid mentioned this pull request Sep 17, 2022
Closed
@srid
Copy link
Owner

srid commented Sep 17, 2022

@mnaoumov Yea, I know. I'm happy to accept the feature itself, but the implementation has to be done differently. See #350

I don't have time to do this right now, so I merged this PR without that syntax.

@srid srid mentioned this pull request Sep 23, 2022
Merged
shivaraj-bh pushed a commit to shivaraj-bh/emanote that referenced this pull request Dec 18, 2023
@mnaoumov @srid
Add support for embedded pdf (srid#341)
8678882 
Co-authored-by: Sridhar Ratnakumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srid srid srid requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8
Development

Successfully merging this pull request may close these issues.
2 participants
@mnaoumov @srid