Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support embedding PDF using regular Markdown syntax #350

Closed
Tracked by #24
srid opened this issue Sep 17, 2022 · 0 comments · Fixed by #351
Closed
Tracked by #24

Support embedding PDF using regular Markdown syntax #350

srid opened this issue Sep 17, 2022 · 0 comments · Fixed by #351
Labels
enhancement New feature or request

Comments

@srid
Copy link
Owner

srid commented Sep 17, 2022 •
edited
Loading

ie., ![](foo.pdf) should also embed the PDF file like it does for images.

This change (made in #341, but reverted) functionally achieves it, but we want to do it in a simpler manner without overloading Heist.Extra with emanote-specific functions. Heist.Extra will eventually be made a library of its own; thus, it should not contain code specific to Emanote templates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow embedding of PDF, video, etc. using image links srid/emanote
1 participant
@srid